-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing xhr and xml_http_request was non-passive. #44
Comments
On second glance my issue may just be an error in rails-contoller-testing, although removing xhr and xml_http_request is still non-passive :) |
They were not removed. For all rails versions that support them they are still there. For Rails version that doesn't support them they were removed, but it was not working anyway since that Rails version don't have that methods. |
1.0.4 released. |
@rafaelfranca thank you for the quick response :) |
Thank you for reporting, in the end it was a oversight in my side. |
Removing xhr and xml_http_request was non-passive and should have been a major version bump.
Tests that were passing using rails-controller-testing 1.0.2 no longer pass with the 1.0.3 release. I'm all for removing the depreciation warning, but it should have been done with a major version bump to give consumers time to upgrade.
Specifically the tests fail with the error:
PR removing xhr and xml_http_request:
#32
The text was updated successfully, but these errors were encountered: