Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop git in gemspec #279

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
require:
- rubocop-packaging

AllCops:
TargetRubyVersion: 2.5
DisabledByDefault: true

Packaging/BundlerSetupInTests:
Enabled: true

Packaging/GemspecGit:
Enabled: true

Packaging/RequireHardcodingLib:
Enabled: true

Packaging/RequireRelativeHardcodingLib:
Enabled: true
4 changes: 4 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,9 @@ else
gem 'nokogiri', '~> 1.6.0'
end

if RUBY_VERSION >= '2.4'
gem 'rubocop-packaging', '~> 0.5'
end

# Specify your gem's dependencies in jquery-rails.gemspec
gemspec
3 changes: 1 addition & 2 deletions jquery-rails.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ Gem::Specification.new do |s|

s.add_dependency "rails-dom-testing", ">= 1", "< 3"

s.files = `git ls-files`.split("\n")
s.executables = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
s.files = Dir["{lib,vendor}/**/*", "CHANGELOG.md", "MIT-LICENSE", "README.md", "VERSIONS.md"]
s.require_path = 'lib'
end
2 changes: 1 addition & 1 deletion test/assert_select_jquery_test.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require 'ostruct'
require 'jquery/assert_select'
require_relative 'test_helper'
require_relative '../lib/jquery/assert_select'

class AssertSelectJQueryTest < ActiveSupport::TestCase
include Rails::Dom::Testing::Assertions::SelectorAssertions
Expand Down