Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates bold attribute to named attribute on preparation for Rails 7.2 #246

Merged

Conversation

rgp
Copy link
Contributor

@rgp rgp commented Apr 2, 2024

Resolves:

DEPRECATION WARNING: Bolding log text with a positional boolean is deprecated and will be removed in Rails 7.2. Use an option hash instead (eg. color("my text", :red, bold: true)).

@mnovelo
Copy link
Collaborator

mnovelo commented Apr 2, 2024

Thank you for this @rgp

For Rails < 7.1, bold: true will be truthy and have the same outcome as true

@mnovelo mnovelo merged commit 1de1f1b into rails-on-services:development Apr 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants