Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handlebar spam messages from code coverage report generation #980

Merged
merged 1 commit into from Feb 4, 2020

Conversation

nephix
Copy link
Contributor

@nephix nephix commented Feb 4, 2020

When running

$ cd raiden-dapp
$ npm run test:unit

we encounter the same spam messages from handlebars like in:

To fix it, I had to remove node_modules and package-lock.json and run npm i again.

The new package-lock.json seems to have pinned a newer version of istanbul-reports that has a fix for this issue.

@nephix nephix added dApp 📱 test Tests related issues labels Feb 4, 2020
@nephix nephix requested a review from kelsos February 4, 2020 14:29
@nephix nephix added this to In progress in Iteration 25 - 05.02.2020 via automation Feb 4, 2020
Copy link
Contributor

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #980 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #980   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files          93       93           
  Lines        3599     3599           
  Branches      728      728           
=======================================
  Hits         3464     3464           
  Misses         79       79           
  Partials       56       56           
Flag Coverage Δ
#dapp 92.35% <ø> (ø) ⬆️
#sdk 97.93% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cdb283...f254bd9. Read the comment docs.

@nephix nephix merged commit e4b216a into raiden-network:master Feb 4, 2020
Iteration 25 - 05.02.2020 automation moved this from In progress to Done Feb 4, 2020
@nephix nephix deleted the fix/test-coverage-report-spam branch February 4, 2020 15:09
@nephix nephix self-assigned this Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dApp 📱 test Tests related issues
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants