Skip to content

Commit

Permalink
tests: use fake objects provided by the fake client
Browse files Browse the repository at this point in the history
The fake client stores the objects after adding a resource version to
them. This is a breaking change introduced in
kubernetes-sigs/controller-runtime#1306.
Therefore we cannot use the fake object that we provided as input to the
the fake client and should use the object obtained from the Get
operation.

Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
  • Loading branch information
raghavendra-talur committed Apr 19, 2021
1 parent 3aab221 commit 5b1a74b
Showing 1 changed file with 10 additions and 1 deletion.
Expand Up @@ -57,7 +57,16 @@ func getTestParams(mockNamespace bool, t *testing.T) (v1.OCSInitialization, reco
},
}

return ocs, request, getReconciler(t, &ocsRecon)
reconciler := getReconciler(t, &ocs)
//The fake client stores the objects after adding a resource version to
//them. This is a breaking change introduced in
//https://github.com/kubernetes-sigs/controller-runtime/pull/1306.
//Therefore we cannot use the fake object that we provided as input to the
//the fake client and should use the object obtained from the Get
//operation.
_ = reconciler.Client.Get(context.TODO(), request.NamespacedName, &ocs)

return ocs, request, reconciler
}

func getReconciler(t *testing.T, objs ...client.Object) OCSInitializationReconciler {
Expand Down

0 comments on commit 5b1a74b

Please sign in to comment.