Skip to content

Commit

Permalink
tests: clarify the TestCreateSCCs test
Browse files Browse the repository at this point in the history
This test ensures that the SCCs are created during the reconcile.

Changing the logic to match the comments.

Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
  • Loading branch information
raghavendra-talur committed Apr 19, 2021
1 parent dee571f commit 36c767d
Showing 1 changed file with 2 additions and 1 deletion.
Expand Up @@ -210,6 +210,7 @@ func TestCreateWatchedResource(t *testing.T) {
}
}

// TestCreateSCCs ensures that the reconciler creates the SCCs if they are missing.
func TestCreateSCCs(t *testing.T) {
testcases := []struct {
label string
Expand All @@ -229,7 +230,7 @@ func TestCreateSCCs(t *testing.T) {
ocs, request, reconciler := getTestParams(false, t)

if tc.sscCreated {
ocs.Status.SCCsCreated = false
ocs.Status.SCCsCreated = true
// TODO: uncomment this!
//err := reconciler.Client.Update(context.TODO(), &ocs)
//assert.NoErrorf(t, err, "[%s]: failed to update ocsInit status", tc.label)
Expand Down

0 comments on commit 36c767d

Please sign in to comment.