Skip to content

Commit

Permalink
chore: add antfu/eslint (#319)
Browse files Browse the repository at this point in the history
* chore: remove old docs from main

* feat: add eslint as root

* chore: run lint:fix

* fix: update vscode settings

* chore: use provided settings

* chore: update build workflows

* fix: nuxt build error

* fix: build pipeline not waiting for radix-vue

* fix: frozen lockfile

* fix: pipeline failing due to pnpm limit

* chore: remove prettier reference

---------

Co-authored-by: Mukund Shah <39938037+mukundshah@users.noreply.github.com>
  • Loading branch information
zernonia and mukundshah committed Aug 21, 2023
1 parent 6a21746 commit 504fa0e
Show file tree
Hide file tree
Showing 463 changed files with 8,210 additions and 42,135 deletions.
17 changes: 17 additions & 0 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
const process = require('node:process')

process.env.ESLINT_TSCONFIG = 'tsconfig.json'

module.exports = {
extends: '@antfu',

rules: {
'@typescript-eslint/no-non-null-asserted-optional-chain': 'off',
'@typescript-eslint/ban-ts-comment': 'warn',
'import/first': 'off',
'import/order': 'off',
'symbol-description': 'off',
'no-console': 'warn',
'max-statements-per-line': ['error', { max: 2 }],
},
}
153 changes: 105 additions & 48 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,63 +14,120 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@v2

- name: Setup Node.js environment
uses: actions/setup-node@v2
with:
node-version: 16

- name: Install dependencies
run: cd packages/radix-vue && npm install

- name: Build
run: cd packages/radix-vue && npm run -r --filter=!docs build

- name: Check for errors
run: |
if [ $? -eq 0 ]; then
echo "Build succeeded"
else
echo "Build failed"
exit 1
fi
- name: Checkout repository
uses: actions/checkout@v2

- name: Setup Node.js environment
uses: actions/setup-node@v2
with:
node-version: 16

- uses: pnpm/action-setup@v2
name: Install pnpm
with:
version: 8
run_install: false

- name: Get pnpm store directory
shell: bash
run: |
echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
- uses: actions/cache@v3
name: Setup pnpm cache
with:
path: ${{ env.STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
- name: Install dependencies
run: pnpm install

- name: Build
run: pnpm --filter radix-vue build

- name: Check for errors
run: |
if [ $? -eq 0 ]; then
echo "Build succeeded"
else
echo "Build failed"
exit 1
fi
lint:
needs: build
runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@v2

- name: Setup Node.js environment
uses: actions/setup-node@v2
with:
node-version: 16

- name: Install dependencies
run: cd packages/radix-vue && npm install

- name: Lint
run: cd packages/radix-vue && npm run lint
- name: Checkout repository
uses: actions/checkout@v2

- name: Setup Node.js environment
uses: actions/setup-node@v2
with:
node-version: 16

- uses: pnpm/action-setup@v2
name: Install pnpm
with:
version: 8
run_install: false

- name: Get pnpm store directory
shell: bash
run: |
echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
- uses: actions/cache@v3
name: Setup pnpm cache
with:
path: ${{ env.STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
- name: Install dependencies
run: pnpm install

- name: Lint
run: pnpm run lint

test:
needs: build
runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@v2

- name: Setup Node.js environment
uses: actions/setup-node@v2
with:
node-version: 16

- name: Install dependencies
run: cd packages/radix-vue && npm install

- name: Test
run: cd packages/radix-vue && npm run test
- name: Checkout repository
uses: actions/checkout@v2

- name: Setup Node.js environment
uses: actions/setup-node@v2
with:
node-version: 16

- uses: pnpm/action-setup@v2
name: Install pnpm
with:
version: 8
run_install: false

- name: Get pnpm store directory
shell: bash
run: |
echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
- uses: actions/cache@v3
name: Setup pnpm cache
with:
path: ${{ env.STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
- name: Install dependencies
run: pnpm install

- name: Test
run: pnpm --filter radix-vue run test
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ coverage
# Editor directories and files
.vscode/*
!.vscode/extensions.json
!.vscode/settings.json
.idea
*.suo
*.ntvs*
Expand Down
6 changes: 5 additions & 1 deletion .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
{
"recommendations": ["Vue.volar"]
"recommendations": [
"Vue.volar",
"Vue.vscode-typescript-vue-plugin",
"dbaeumer.vscode-eslint"
]
}
21 changes: 21 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"prettier.enable": false,
"editor.formatOnSave": false,
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true,
"source.organizeImports": false
},

"eslint.validate": [
"javascript",
"javascriptreact",
"typescript",
"typescriptreact",
"vue",
"html",
"markdown",
"json",
"jsonc",
"yaml"
]
}
4 changes: 0 additions & 4 deletions docs/.eslintignore

This file was deleted.

8 changes: 0 additions & 8 deletions docs/.eslintrc.cjs

This file was deleted.

12 changes: 0 additions & 12 deletions docs/.gitignore

This file was deleted.

2 changes: 0 additions & 2 deletions docs/.npmrc

This file was deleted.

57 changes: 0 additions & 57 deletions docs/README.md

This file was deleted.

41 changes: 0 additions & 41 deletions docs/app.config.ts

This file was deleted.

0 comments on commit 504fa0e

Please sign in to comment.