Add SSR testing playground setup #455
Conversation
| const path = require('path'); | ||
| const withTM = require('next-transpile-modules')([]); | ||
|
|
||
| module.exports = withTM({ | ||
| webpack(config) { | ||
| // https://github.com/josephluck/next-typescript-monorepo/blob/master/blog/next.config.js | ||
| const babelRule = config.module.rules.find((rule) => | ||
| rule.use && Array.isArray(rule.use) | ||
| ? rule.use.find((u) => u.loader === 'next-babel-loader') | ||
| : rule.use.loader === 'next-babel-loader' | ||
| ); | ||
|
|
||
| if (babelRule) { | ||
| babelRule.include.push(path.resolve('../')); | ||
| } | ||
|
|
||
| return config; | ||
| }, | ||
| }); |
There was a problem hiding this comment.
This took me ages to figure out, it works but I don't really get how…
There was a problem hiding this comment.
well if it works, I guess that's all we need haha. It's just an internal thing anyway 🤷♀️
| @@ -0,0 +1,18 @@ | |||
| import * as React from 'react'; | |||
| import { RadioGroup, RadioGroupItem, RadioGroupIndicator } from '@radix-ui/react-radio-group'; | |||
There was a problem hiding this comment.
We're able to import the packages like this, and they import the source and everything rebuilds and hot reloads when making changes.
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "extends": "../tsconfig.json", | |||
There was a problem hiding this comment.
Extending our base config to get the path mapping
|
awww man 😢 now getting this build error here in CI…
|
benoitgrelard
force-pushed
the
ssr-setup
branch
from
ef8487c
to
d84b134
Compare
benoitgrelard
force-pushed
the
ssr-setup
branch
from
406bd7e
to
2455af0
Compare
| @@ -31,7 +32,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/core": "^7.0.0", | |||
| "@stitches/react": "canary", | |||
| "@stitches/react": "0.0.3-canary.4", | |||
There was a problem hiding this comment.
I had to fix this to latest alpha because they've been publishing new betas and as I've busted the yarn lock we were getting the new API. I don't want to do this work now which will muddy the waters of what this PR is about.
| "resolutions": { | ||
| "chokidar": "3.4.3" | ||
| }, |
There was a problem hiding this comment.
So, even after all my efforts trying to install next manually, I couldn't get it to work (still got that hunk error) and any yarn from scratch would give that error anyway.
Adding this resolution fixes the issue as suggested here: vercel/next.js#21343 (comment) (although I suspect that typed the version number wrong because they're referring to the new one rather than old one)
There was a problem hiding this comment.
For posterity:
As the above linked issue suggests, yarn 2.4.0 fixed that issue but we have another issue which prevents us from updating. parcel-bundler/parcel#4064 (comment)
That seems to have appeared between 2.1.1 (which we are on right now) and 2.2.0.
| @@ -1852,7 +1855,7 @@ function scrollAreaStateReducer( | |||
| // Alternatively we could reconsider exposing the Position component, or we could allow users to | |||
| // pass their own positionRef with a prop. | |||
| function useExtendedScrollAreaRef( | |||
| forwardedRef: React.ForwardedRef<any>, | |||
| forwardedRef: React.Ref<any>, | |||
There was a problem hiding this comment.
No idea what happened with this file! But somehow this TS error got flagged because React.ForwardedRef is not a thing. I have no idea how this went through for months…
On top of that all the other changes are just prettier, again not sure how it went in not formatted…
For both reasons above I've declined a package update for this as it's just internal.
This PR:
ssr-testingwith a nextjs project