Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test with devcontainer CLI #65

Merged
merged 1 commit into from Jul 18, 2022
Merged

ci: test with devcontainer CLI #65

merged 1 commit into from Jul 18, 2022

Conversation

lsorber
Copy link
Member

@lsorber lsorber commented Jun 27, 2022

Uses the new devcontainers/ci GitHub Action to test the Dev Container directly, instead of creating a local Python environment as we do now.

EDIT: Because of devcontainers/ci#148, we'll use the devcontainers CLI instead.

@lsorber lsorber requested a review from sinopeus June 27, 2022 13:54
@lsorber lsorber self-assigned this Jun 27, 2022
@lsorber lsorber marked this pull request as draft June 27, 2022 17:06
@lsorber lsorber changed the title ci: test cookiecutter's dev container ci: test with dev container CLI Jun 28, 2022
@lsorber
Copy link
Member Author

lsorber commented Jun 29, 2022

Update: this PR should be good to go, but the CI will fail until requests v2.28.1 is released.

@lsorber lsorber changed the title ci: test with dev container CLI ci: test with devcontainer CLI Jun 29, 2022
@lsorber lsorber marked this pull request as ready for review June 30, 2022 07:12
ci: explicitly disable image pushing

ci: add required imageName

ci: switch to devcontainers cli

ci: add buildkit flag

ci: add buildkit env var

ci: git init package for poe lint

ci: test before lint

ci: debug ci

ci: add git add

ci: refactor steps

ci: debug ci

ci: bump deps

ci: try jit git add

ci: touch gitconfig

ci: different gitconfig

ci: refactor steps

ci: replace deprecated -g flag

ci: clean up
Copy link
Collaborator

@sinopeus sinopeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's easy to use! Looks good to me. Do the underlying Docker builds use cache? 🙂 In any case it's already a very nice improvement so let's get this merged.

@lsorber
Copy link
Member Author

lsorber commented Jul 18, 2022

Oh, that's easy to use! Looks good to me. Do the underlying Docker builds use cache? 🙂 In any case it's already a very nice improvement so let's get this merged.

Thanks! No, I don't think this uses any Docker image caching yet. Once devcontainers/ci#148 is resolved, we can switch to the GitHub Action, which should benefit from image caching.

@lsorber lsorber merged commit 0316533 into main Jul 18, 2022
@lsorber lsorber deleted the ls-devcontainer-ci branch July 18, 2022 14:30
@lsorber lsorber mentioned this pull request Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants