-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove install dependency + support Python 3.9, 3.10 #647
Conversation
Also upgrade publib dependency in requirements.txt to
I just published a new version of the package (https://pypi.org/project/publib/ ) that fixes a non compatibility with Matplotlib 3.8.0 |
Regarding the test failures, see my comment here: https://github.com/radis/radis/pull/633/files#r1555134045 |
Co-authored-by: Erwan Pannier <erwan.pannier@gmail.com>
…nto simplified_versions_instal
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #647 +/- ##
===========================================
+ Coverage 72.92% 72.94% +0.01%
===========================================
Files 148 148
Lines 21066 21066
===========================================
+ Hits 15363 15366 +3
+ Misses 5703 5700 -3 |
@@ -1,7 +1,7 @@ | |||
# Installed by "pip install -e .[dev]" as well as "conda env create --file environment.yml" | |||
lxml # parser used for ExoMol website | |||
hjson # Json with comments (for default_radis.json) | |||
publib>=0.4.0 # Plotting styles for Matplotlib. Version, see #647 | |||
publib>=0.3.2 # Plotting styles for Matplotlib. Version, update to 0.4.0 needed for matplotlib==3.8. However, only 0.3.2 is compatible with python==3.8 (see #647) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
therefore test on python>=3.11 or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry I didn't get it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vaex is not compatible with python>3.8 (see original post). matplotlib==3.8 requires python>3.8, thus, we should hold this update for the moment
@erwanp, waiting for your final review on this. I will try to sort the docs by tonight |
To summarize, when vaex will move to a higher python version we will be able to:
|
Which is actively being worked on : vaexio/vaex#2331 (@minouHub register to this PR to know when it is released) |
@erwanp did you change this PR name because you want to wait for vaex? I would have prefer to merge now and put the support of Python 3.11 on a to-do list |
@minouHub ok I updated the PR title |
We have an installation problem because of
What is the reason for this restriction? |
Hello,
The problem was that the error message was hard to understand. With this requirement, it's clearer. In the past, you could somehow trick the install with the developer install The main strategy I applied was to wait for |
@minouHub Thanks. I see. The problem is that jax requires python >3.8. so, for us, it is a big problem. Can you revert this modification for a while if you do not have a big problem? |
oh wait .... it worked .... I'm trying a quick fix in #651. Will keep you updated |
Ah, I see. Thanks for the quick check! |
Hello,
|
@minouHub thank you so much! |
If and only if vaex is installed through Conda and not Pip on our side; which it is=> so all good. Well done for fixing it |
This PR is to attempt to remove dependencies in the install of RADIS. Each push will be tested for one of the requirements of
environment.yaml
Also:
python<3.9
insetup.py
for pip install