Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes invalidindex error #428

Merged
merged 2 commits into from
Mar 20, 2022
Merged

fixes invalidindex error #428

merged 2 commits into from
Mar 20, 2022

Conversation

erwanp
Copy link
Member

@erwanp erwanp commented Mar 19, 2022

Description

replace .at() by .loc() . Fixes #427

@erwanp erwanp added this to the 0.12.1 milestone Mar 19, 2022
@anandxkumar
Copy link
Collaborator

anandxkumar commented Mar 19, 2022

tested the same on my system, test_array 2 tests fails. One is caused by AssertionError: assert 'numpy' == 'cython' and other on my system says ModuleNotFoundError: No module named 'radis_cython_extensions' where as on Travis says value error which happens when radis_cython_extensions successfully gets imported. Due to the same radis_cython_extensions the 2 tests in test_examples fails.

Why locally pytest says ModuleNotFoundError: No module named 'radis_cython_extensions'. pip install -e .[dev] -v is not passing all the tests (missing dependencies like the above), it might need to be updated.

@erwanp
Copy link
Member Author

erwanp commented Mar 20, 2022

Cython build failed recently, causing the errors above.

I found out it was because we specify Cython & numpy requirements both in https://github.com/radis/radis/blob/develop/pyproject.toml (the new python standard) as well as in the setup.py (setuptools standard)

Things will be smoother once Setuptools totally supports pyproject.toml (which is being worked on : pypa/setuptools#2970 )

Interesting read : https://stackoverflow.com/questions/64150719/how-to-write-a-minimally-working-pyproject-toml-file-that-can-install-packages

@erwanp erwanp added the ci-dev continum-integration, tests, and development workflow label Mar 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #428 (93c394b) into develop (8416766) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #428      +/-   ##
===========================================
- Coverage    77.10%   77.08%   -0.03%     
===========================================
  Files          161      161              
  Lines        18664    18664              
===========================================
- Hits         14391    14387       -4     
- Misses        4273     4277       +4     

@erwanp erwanp merged commit 904477d into radis:develop Mar 20, 2022
@erwanp erwanp deleted the fix/invalidindex branch March 20, 2022 19:40
@anandxkumar
Copy link
Collaborator

@erwanp the code quality check failed. I haven't seen error similar to the below:
The command "eval git fetch origin +refs/pull/428/merge: " failed 3 times.

@erwanp
Copy link
Member Author

erwanp commented Mar 20, 2022

I think it failed because I merged before the end of the linting-tests. Physics/executing-tests are fine, we're all good !

@erwanp erwanp mentioned this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-dev continum-integration, tests, and development workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pandas InvalidIndexError error in df.at
3 participants