-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes invalidindex error #428
Conversation
tested the same on my system, Why locally pytest says |
…ties for cython/numpy
Cython build failed recently, causing the errors above. I found out it was because we specify Cython & numpy requirements both in https://github.com/radis/radis/blob/develop/pyproject.toml (the new python standard) as well as in the setup.py (setuptools standard) Things will be smoother once Setuptools totally supports pyproject.toml (which is being worked on : pypa/setuptools#2970 ) Interesting read : https://stackoverflow.com/questions/64150719/how-to-write-a-minimally-working-pyproject-toml-file-that-can-install-packages |
Codecov Report
@@ Coverage Diff @@
## develop #428 +/- ##
===========================================
- Coverage 77.10% 77.08% -0.03%
===========================================
Files 161 161
Lines 18664 18664
===========================================
- Hits 14391 14387 -4
- Misses 4273 4277 +4 |
@erwanp the code quality check failed. I haven't seen error similar to the below: |
I think it failed because I merged before the end of the linting-tests. Physics/executing-tests are fine, we're all good ! |
Description
replace .at() by .loc() . Fixes #427