Fix smallvec vulnerability #502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
The field db-url is deprecated and db-urls should be used instead. Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
We force the smallvec dependency to be 1.6.1 due to the vulnerability outlined in the issue here Amanieu/parking_lot#274. We depend on governor which in turn depends on parking_lot. Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
kim
reviewed
Jan 27, 2021
librad/Cargo.toml
Outdated
| # parking_lot, which depends on smallvec. There is vulnerability | ||
| # in v1.0 and so we're forcing cargo to use this version instead. | ||
| [dependencies.smallvec] | ||
| version = "1.6.1" |
There was a problem hiding this comment.
Can we say >= 1.6.1, 1.6?
Also, how do we know this is no longer needed? Can we know? What can we know? Are we?
There was a problem hiding this comment.
Can we say >= 1.6.1, 1.6?
Ya, >= 1.6.1 would include the fix 👍
Also, how do we know this is no longer needed? Can we know? What can we know? Are we?
lol, I'll include this link boinkor-net/governor#60. Once that's in and bumped we could drop this.
And link governor issue. Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com>
kim
approved these changes
Jan 28, 2021
|
Closed via 41c216b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We force the smallvec dependency to be 1.6.1 due to the vulnerability
outlined in the issue here Amanieu/parking_lot#274.
We depend on governor which in turn depends on parking_lot.
Also updating the field
db-urltodb-urls, and outputting the version of cargo deny for inspection sake.