Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node version to 18.12.0 LTS #431

Merged
merged 1 commit into from
Nov 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/check-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ jobs:
check-build:
runs-on: ubuntu-latest
steps:
- name: Setup Node
uses: actions/setup-node@v1
with:
node-version: '18.12.1'
- uses: actions/checkout@v2
- run: npm ci
- run: npm run build
4 changes: 4 additions & 0 deletions .github/workflows/check-format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ jobs:
check-format:
runs-on: ubuntu-latest
steps:
- name: Setup Node
uses: actions/setup-node@v1
with:
node-version: '18.12.1'
- uses: actions/checkout@v2
- run: npm ci
- run: ./scripts/check-format
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v1
with:
node-version: '16.16.0'
node-version: '18.12.1'
- name: Checkout
uses: actions/checkout@v2
- name: Cypress run
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v1
with:
node-version: '16.16.0'
node-version: '18.12.1'
- name: Checkout
uses: actions/checkout@v2
- run: npm ci
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ jobs:
check:
runs-on: ubuntu-latest
steps:
- name: Setup Node
uses: actions/setup-node@v1
with:
node-version: '18.12.1'
- uses: actions/checkout@v2
- run: npm ci
- run: npm run check
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
18.12.1
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nodejs 16.13.2
nodejs 18.12.1
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"type": "module",
"engines": {
"node": ">=14"
"node": ">=18.12.1"
},
"devDependencies": {
"@rsksmart/mock-web3-provider": "^1.0.1",
Expand Down
3 changes: 3 additions & 0 deletions vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ const config: UserConfig = {
pluginRewriteAll(),
],
server: {
// We have to set host here, otherwise CI binds to the ipv6 address and
// e2e tests don't work.
host: "127.0.0.1",
port: 3000,
},
resolve: {
Expand Down