Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #401

Closed
wants to merge 7 commits into from
Closed

Upgrade dependencies #401

wants to merge 7 commits into from

Conversation

rudolfs
Copy link
Member

@rudolfs rudolfs commented Sep 21, 2022

I ran npx npm-check -u.

  • upgrade patch level deps
  • upgrade minor level deps
  • upgrade major level deps
  • upgrade to node v18

Didn't upgrade the gnosis deps, because I didn't want to invest time on deprecated orgs stuff:

@gnosis.pm/safe-core-sdk        0.3.1  ❯  3.1.1  https://github.com/safe-global/safe-core-sdk#readme
@gnosis.pm/safe-core-sdk-types  0.1.1  ❯  1.6.1  https://github.com/safe-global/safe-core-sdk#readme
@gnosis.pm/safe-service-client  0.1.1  ❯  1.3.1  https://github.com/safe-global/safe-core-sdk#readme

⚠️ Important notes: ⚠️

  • the Ceramic upgrade required bumping our build target to es2020
  • after the vite upgrade i had to bind the local dev server to 127.0.0.1 specifically, otherwise CI would fail, I assume it's because it would otherwise bind to the ipv6 address
  • this needs extensive testing

@rudolfs rudolfs force-pushed the rudolfs/upgrade-deps branch 5 times, most recently from dff15f0 to c2353de Compare September 23, 2022 13:27
@rudolfs rudolfs marked this pull request as ready for review September 23, 2022 13:28
cypress.config.ts Outdated Show resolved Hide resolved
Copy link
Member

@sebastinez sebastinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far looking nice!
Kudos again for updating the the component testing library to work directly with the Cypress v10 config, didn't realize this came out, so much nicer!
Also the changes to the ordering of imports is nice 👍

Left one comment that threw a compiler error on my system, maybe we can add that

Will have to investigate also the changes in the Gnosis SDKs.

src/SeedAddress.spec.ts Outdated Show resolved Hide resolved
@sebastinez

This comment was marked as resolved.

@rudolfs
Copy link
Member Author

rudolfs commented Sep 23, 2022

TBD:

  • fix console warnings
browser-external:buffer:9 Module "buffer" has been externalized for browser compatibility. Cannot access "buffer.Buffer" in client code.
Module "util" has been externalized for browser compatibility. Cannot access "util.debuglog" in client code.
browser-external:util:9 Module "util" has been externalized for browser compatibility. Cannot access "util.inspect" in client code.
Module "util" has been externalized for browser compatibility. Cannot access "util.debuglog" in client code.
Module "util" has been externalized for browser compatibility. Cannot access "util.inspect" in client code.

@rudolfs

This comment was marked as resolved.

@sebastinez

This comment was marked as resolved.

@sebastinez

This comment was marked as resolved.

@sebastinez

This comment was marked as resolved.

@rudolfs rudolfs force-pushed the rudolfs/upgrade-deps branch 2 times, most recently from 58ee943 to 8fc6697 Compare September 23, 2022 18:46
@rudolfs

This comment was marked as resolved.

@rudolfs rudolfs marked this pull request as draft September 23, 2022 18:50
@rudolfs

This comment was marked as resolved.

Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
@rudolfs rudolfs force-pushed the rudolfs/upgrade-deps branch 4 times, most recently from d1764d0 to cbc3131 Compare September 26, 2022 15:40
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
@rudolfs rudolfs force-pushed the rudolfs/upgrade-deps branch 2 times, most recently from 4e74ee5 to 14baa94 Compare September 26, 2022 15:54
@rudolfs rudolfs marked this pull request as ready for review September 26, 2022 16:02
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
Signed-off-by: Rūdolfs Ošiņš <rudolfs@osins.org>
@rudolfs rudolfs marked this pull request as draft September 27, 2022 13:52
@rudolfs
Copy link
Member Author

rudolfs commented Sep 29, 2022

Superseded by #427.

@rudolfs rudolfs closed this Sep 29, 2022
@rudolfs rudolfs deleted the rudolfs/upgrade-deps branch September 30, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants