New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify code and test #18

Merged

radarhere merged 1 commit into radarhere:multiline_centered_embedded_color from nulano:float_text_coord

Aug 25, 2022

nulano commented Aug 24, 2022

For python-pillow#6517

Changes proposed in this pull request:

Slightly simplify coord rounding.
While multiline text might be what caused the issue report, I'd suggest explicitly passing float coords to the text function. This can also be tested for all font modes.
While testing, I found that the test_standard_embedded_color epsilon can now be decreased.


          simplify code, make test more generic

7d126ee

nulano mentioned this pull request

Round box position to integer when pasting embedded color python-pillow/Pillow#6517

Merged

radarhere merged commit 18bd77b into radarhere:multiline_centered_embedded_color

nulano deleted the float_text_coord branch

August 25, 2022 12:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment