feat: switch back to nautobot helm chart #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So leaving this as draft because the |
cardoe
force-pushed
the
nautobot-helm-chart
branch
2 times, most recently
from
6449e8c
to
55ff9e9
Compare
|
I think it's not working because of argoproj/argo-cd#13220 |
cardoe
force-pushed
the
nautobot-helm-chart
branch
3 times, most recently
from
11938d7
to
e68160c
Compare
The upstream helm chart has been fixed with the patches we need so there's no reason to include the rendered helm chart any longer. Unfortunately there's a breaking change here around how the NAUTOBOT_SECRET_KEY is handled which can only be supplied via a helm variable and not via a reference.
We haven't determined how we'll keep our versions up to date, but drop this for now to follow the chart version.
Don't require the dex cred for nautobot's celery workers since they don't have it mounted in.
cardoe
force-pushed
the
nautobot-helm-chart
branch
from
9171af2
to
62d14bd
Compare
|
Alright came up with a work around by using the URL to this repo. I'll try and see if I can't submit a fix upstream for ArgoCD. |
|
This change will drag us forward to Nautobot 2.1.9 as well since that's what the helm charts package. |
nicholaskuechler
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch back to using the nautobot helm chart now that the fixes are merged upstream. This will allow us to remain current with nautobot releases going forward.