Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused rack classes #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unused rack classes #10

wants to merge 1 commit into from

Conversation

p8
Copy link

@p8 p8 commented Aug 25, 2023

These are no longer autoloaded so they can be removed.
See:
rack/rack@fd7e0ad
rack/rack#2113 (comment)

These are no longer autoloaded so they can be removed.
See:
rack/rack@fd7e0ad
@ioquatix
Copy link
Member

I don't think we can merge this as it will break compatibility. However, I'll check tomorrow.

@dentarg
Copy link

dentarg commented Aug 26, 2023

If merged and released in a new major version of the rackup gem, this could be okay? The Rack upgrade guide does mention classes were renamed. The guide could be amended to mention in which rackup version the old classes was removed.

@ioquatix
Copy link
Member

Yes, that would be totally fine, however my suggestion is, there is no hurry to do this, and the sooner we do it, the more pain we will cause. So, IMHO, let's wait until Rack 3.0 and Rails 7.1 is well and truly out the door, maybe even Rails 8.0 - Rack 2.x will likely be deprecated around that time, then this change will be painless. Unless there is some value in doing it sooner, I'd vote we wait to avoid creating potential pain for users.

@dentarg
Copy link

dentarg commented Aug 26, 2023

Totally agree with that.

@p8
Copy link
Author

p8 commented Aug 28, 2023

If we are going to keep these for a while, should the autoload logic be copied to rackup instead?
If a new version of Rack is released, the Rack::Server and Rack::Handler no longer get autoloaded.

@ioquatix
Copy link
Member

ioquatix commented Aug 28, 2023

I think that’s reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants