Remove unused ostruct require
#2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenStruct usage was removed in rack#2004 but this was missed. In Ruby 3.5 this require would trigger a warning
ioquatix
approved these changes
Apr 2, 2024
|
Thanks! |
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Apr 10, 2024
…4.0dev This commit addresses Rails Nightly CI failure at https://buildkite.com/rails/rails-nightly/builds/391#018ec54f-a2ef-40de-9749-6cc3ecae4ebd/1368-1376 ```ruby $ ruby -v ruby 3.4.0dev (2024-04-09T16:29:01Z master 0107954f25) [x86_64-linux] $ bin/test test/command/help_integration_test.rb:33 Run options: --seed 3363 F Failure: Rails::Command::HelpIntegrationTest#test_prints_help_via_`X:help`_command_when_running_`X`_and_`X:X`_command_is_not_defined [test/command/help_integration_test.rb:37]: --- expected +++ actual @@ -1,4 +1,5 @@ -"Commands: +"/home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/zeitwerk-2.6.13/lib/zeitwerk/kernel.rb:34: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Add ostruct to your Gemfile or gemspec. +Commands: bin/rails dev:cache # Toggle development mode caching on/off bin/rails dev:help [COMMAND] # Describe available commands or one specific... bin/test test/command/help_integration_test.rb:33 Finished in 0.738986s, 1.3532 runs/s, 1.3532 assertions/s. 1 runs, 1 assertions, 1 failures, 0 errors, 0 skips $ ``` This commit can be reverted once both rack and jbuilder take care of it. Related to rack/rack#2166 rails/jbuilder#561
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenStruct usage was removed in #2004 but this was missed.
In Ruby 3.4 this is likely to trigger a warning, see ruby/ruby#10428 / https://bugs.ruby-lang.org/issues/20309