Cloudfront forwarded proto header #2089
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyevans
requested changes
Jun 26, 2023
…overwritten by vendor header value
jeremyevans
requested changes
Jun 27, 2023
Great. Thanks for the speedy and clear feedback on the review |
|
Do you mind checking why the tests are failing?
|
|
will have a look tomorrow.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok - taking another swing at solving #2080
This time where we can pass any header in and the value of that will be copied to the value of
HTTP_X_FORWARDED_PROTOThis allows the user to rely on the value in
CloudFront-Forwarded-Protoprovided by AWS Cloudfront. If other vendors have custom headers for this, then this should also provide an option.