Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate automatic cache invalidation in Request#{GET,POST} #2073

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Deprecate automatic cache invalidation in Request#{GET,POST} #2073

wants to merge 1 commit into from

Commits on Apr 25, 2023

  1. Deprecate automatic cache invalidation in Request#{GET,POST} 

    Add Request#clear_{GET,POST} for users to perform manual cache
invalidation when replacing env['QUERY_STRING'] or env['rack.input'].

With this invalidation, env[RACK_REQUEST_QUERY_STRING] and
env[RACK_REQUEST_FORM_INPUT] are unnecessary.

It appears as though env[RACK_REQUEST_FORM_VARS] is already
unnecessary, as the value is set but never accessed, dating back to
its introduction in 6c80c6c.
However, even though it is never used by Rack, it apparently is
used by Rails.  However, Rails usage appears to be limited to
parameter filtering, and if the RACK_REQUEST_FORM_VARS key wasn't
set, there would be nothing to filter.  So it's possible Rails
could be changed so that if the key was missing, there are no
problems (maybe it works like that already, and only the Rails
tests need updates).
    @jeremyevans
    jeremyevans committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    a5691a5 View commit details
    Browse the repository at this point in the history