Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to & as separator instead of either & or ; #2043

Closed

Conversation

mimosa
Copy link

@mimosa mimosa commented Mar 3, 2023

Allowing ; as separator by default can lead to web cache poisoning.

Fixes #1732

@mimosa
Copy link
Author

mimosa commented Mar 3, 2023

@rafaelfranca Hi, I need to patch on rack2 because I use Rails 6 in the production env and need to pass snyk's security check.

@jeremyevans
Copy link
Contributor

I don't think we are planning to backport this change to Rack 2.2, due to the backwards compatibility issues. See #1732 and #1733.

@mimosa
Copy link
Author

mimosa commented Mar 3, 2023

I don't think we are planning to backport this change to Rack 2.2, due to the backwards compatibility issues. See #1732 and #1733.

I understand that 2.2 is a maintained version and this pr is just a security patch, isn't that right?

@jeremyevans
Copy link
Contributor

This isn't "just a security patch", it's also a backwards incompatible change that will break applications relying on the feature.

@mimosa
Copy link
Author

mimosa commented Mar 6, 2023

Thanks @jeremyevans, I will reconsider the changes this fix brings to rack 2.2 and our project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants