Make env['rack.input'] optional.
#2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
optional-input
branch
2 times, most recently
from
ec67f1b
to
9c4360c
Compare
|
Ignore the failures in 2.5, it's done this before and seems an issue with rubygems/bundler/ruby-setup AFAICT. |
ioquatix
force-pushed
the
optional-input
branch
2 times, most recently
from
636567b
to
271699d
Compare
jeremyevans
requested changes
Jan 19, 2023
There was a problem hiding this comment.
This will be OK once the the Ruby 2.4/2.5 CI removal is no longer included. I fixed the CI tests for Ruby 2.5 in #2021.
|
@ioquatix Can you remove the first commit and then rebase on master? Then this should be good to merge. |
ioquatix
force-pushed
the
optional-input
branch
from
271699d
to
3a7a8ba
Compare
|
Okay done. |
ioquatix
force-pushed
the
optional-input
branch
from
3a7a8ba
to
46f67a2
Compare
ioquatix
force-pushed
the
optional-input
branch
from
46f67a2
to
c993a37
Compare
jeremyevans
approved these changes
Jan 20, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1994. Fixes #1995.