Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.2-stable] Rack::MethodOverride handle QueryParser::ParamsTooDeepError #2011

Merged
merged 1 commit into from Jan 16, 2023
Merged

[2.2-stable] Rack::MethodOverride handle QueryParser::ParamsTooDeepError #2011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rack/method_override.rb
View file
Open in desktop
Expand Up @@ -43,7 +43,7 @@ def allowed_methods

def method_override_param(req)
req.POST[METHOD_OVERRIDE_PARAM_KEY]
rescue Utils::InvalidParameterError, Utils::ParameterTypeError
rescue Utils::InvalidParameterError, Utils::ParameterTypeError, QueryParser::ParamsTooDeepError
req.get_header(RACK_ERRORS).puts "Invalid or incomplete POST params"
rescue EOFError
req.get_header(RACK_ERRORS).puts "Bad request content body"
Expand Down
7 changes: 7 additions & 0 deletions test/spec_method_override.rb
View file
Open in desktop
Expand Up @@ -100,6 +100,13 @@ def app
env[Rack::RACK_ERRORS].read.must_match /Bad request content body/
end

it "not modify REQUEST_METHOD for POST requests when the params are unparseable because too deep" do
env = Rack::MockRequest.env_for("/", method: "POST", input: ("[a]" * 36) + "=1")
app.call env

env["REQUEST_METHOD"].must_equal "POST"
end

it "not modify REQUEST_METHOD for POST requests when the params are unparseable" do
env = Rack::MockRequest.env_for("/", method: "POST", input: "(%bad-params%)")
app.call env
Expand Down