Rack::Request#POST should consistently raise errors.
#2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
rack-request-form-error
branch
from
860beef
to
3a3f2a0
Compare
ioquatix
changed the title
Rack::Request#post should consistently raise errors.Rack::Request#POST should consistently raise errors.
jeremyevans
requested changes
Jan 16, 2023
jeremyevans
approved these changes
Jan 16, 2023
ioquatix
force-pushed
the
rack-request-form-error
branch
from
c382e35
to
62aebff
Compare
Cache errors that occur when invoking `Rack::Request#POST` so they can be raised again later.
ioquatix
force-pushed
the
rack-request-form-error
branch
from
62aebff
to
36977c2
Compare
ioquatix
added a commit
that referenced
this pull request
Jan 16, 2023
Cache errors that occur when invoking `Rack::Request#POST` so they can be raised again later. * Don't throw exactly the same error - so we have the correct backtrace.
tenderlove
added a commit
that referenced
this pull request
Jan 17, 2023
* 3-0-sec: (24 commits) bump version Update changelog Fix ReDoS vulnerability in multipart parser Fix ReDoS in Rack::Utils.get_byte_ranges Forbid control characters in attributes Bump patch version. `Rack::Request#POST` should consistently raise errors. (#2010) Fix Rack::Lint error message for HTTP_CONTENT_TYPE and HTTP_CONTENT_LENGTH (#2007) Rack::MethodOverride handle QueryParser::ParamsTooDeepError (#2006) Bump patch version. Fix Regexp deprecated third argument with Regexp::NOENCODING (#1998) Update tests to work on latest Rubies. (#1999) Bump patch version. Allow passing through streaming bodies. (#1993) Remove unnecessary executable bit from test files (#1992) Fix Utils.build_nested_query to URL-encode all query string fields (#1989) Trim trailing white space throughout the project (#1990) Fix some typos (#1991) Remove leading dot to fix compatibility with latest cgi gem. (#1988) Fix outdated Rack::Builder rdocs and remove Lobster references (#1986) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache errors that occur when invoking
Rack::Request#POSTso they can be raised again later (consistently).I propose we backport this to
3-0-stableas this is a regression on 2.2 behaviour.Fixes #2009.