Make Rack::Request#{[],[]=} warn even in non-verbose mode #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenderlove
approved these changes
Jul 14, 2020
Additionally, use the :uplevel keyword to warn, so it includes the caller information in the warning output (similar to rb_warn). This only works on Ruby 2.5+, so output will look a little odd on Ruby 2.3/2.4, but I don't think it warrants separate handling in older versions. Fixes rack#1277
jeremyevans
force-pushed
the
non-verbose-request-aref-1277
branch
from
e3a0279
to
058fa08
Compare
|
Would it make more sense to remove these methods for Rack 3.0? Rack 4.0? |
|
They were only warned in non-verbose mode before, so going directly to removed is likely to break things. We can probably remove them in Rack 3.1 or 4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, use the :uplevel keyword to warn, so it includes
the caller information in the warning output (similar to rb_warn).
This only works on Ruby 2.5+, so output will look a little odd on
Ruby 2.3/2.4, but I don't think it warrants separate handling in
older versions.
Fixes #1277