New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework host/hostname/authority implementation. #1561
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
488dae7
Add specs to better match implementation of `URI.host` and `URI.hostn…
ioquatix 26e4d7c
Add `HTTP_PORT` constant for consistency.
ioquatix b9b87a7
Add documentation for `HTTP_X_FORWARDED_*` constants.
ioquatix 7e899c8
Improve `Rack::Request#authority` and related methods.
ioquatix 66ea112
Relax requirement as it breaks tests.
ioquatix aa68f07
Add entry to CHANGELOG.
ioquatix dc44973
Add entry to CHANGELOG, minor improvements as discussed.
ioquatix a146b6a
Prefer implicit returns.
ioquatix eb7de84
Document AUTHORITY regexp.
ioquatix eec2635
Allow SERVER_PORT to be a string containing a port number.
ioquatix 05212cd
Add documentation to `Rack::Request#hostname`.
ioquatix File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we state that
SERVER_PORT must be an integer
, we should doenv["SERVER_PORT"].is_a?(Integer)
. I don't think we need to check that it is convertable to an integer, unless we want that to be the spec.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, makes sense, I'll update the SPEC.