Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SessionId#to_s be an alias of #public_id #1462

Merged
merged 1 commit into from Jan 10, 2020
Merged

Make SessionId#to_s be an alias of #public_id #1462

merged 1 commit into from Jan 10, 2020

Commits on Jan 9, 2020

  1. Make SessionId#to_s be an alias of #public_id 

    This restores backwards compatibility with code that uses the
session id.

No justification was given for making to_s raise in the commit
that changed the behavior (cc1d162).

If there is a reason to keep raising an exception, a specific
exception class and explicit error message should be used.
    @jeremyevans
    jeremyevans committed Jan 9, 2020
    Copy the full SHA
    88324d7 View commit details
    Browse the repository at this point in the history