Fix: Add `to_hash` to wrap Hash and Session classes on `stringify_keys` #1428

oleh-demyanyuk · 2019-12-16T09:51:44Z

When using Rails application and go to Sidekiq Web management page I've got the following error:

undefined method 'transform_keys' for #<ActionDispatch::Request::Session:0x00007f8fa6d3bcc8>

With code :

        def stringify_keys(other)
          other.transform_keys(&:to_s) # <-- Error happened here
        end
      end

Application Trace:

/Users/olehd/.rvm/gems/ruby-2.3.7/bundler/gems/rack-e82f06b354fa/lib/rack/session/abstract/id.rb:185:in `stringify_keys'
/Users/olehd/.rvm/gems/ruby-2.3.7/bundler/gems/rack-e82f06b354fa/lib/rack/session/abstract/id.rb:121:in `update'
/Users/olehd/.rvm/gems/ruby-2.3.7/bundler/gems/rack-e82f06b354fa/lib/rack/session/abstract/id.rb:290:in `prepare_session'
/Users/olehd/.rvm/gems/ruby-2.3.7/bundler/gems/rack-e82f06b354fa/lib/rack/session/abstract/id.rb:249:in `context'
/Users/olehd/.rvm/gems/ruby-2.3.7/bundler/gems/rack-e82f06b354fa/lib/rack/session/abstract/id.rb:244:in `call'
/Users/olehd/.rvm/gems/ruby-2.3.7/bundler/gems/rack-e82f06b354fa/lib/rack/urlmap.rb:77:in `block in call'
/Users/olehd/.rvm/gems/ruby-2.3.7/bundler/gems/rack-e82f06b354fa/lib/rack/urlmap.rb:61:in `each'
/Users/olehd/.rvm/gems/ruby-2.3.7/bundler/gems/rack-e82f06b354fa/lib/rack/urlmap.rb:61:in `call'
/Users/olehd/.rvm/gems/ruby-2.3.7/bundler/gems/rack-e82f06b354fa/lib/rack/builder.rb:176:in `call'
sidekiq (5.2.7) lib/sidekiq/web.rb:103:in `call'
sidekiq (5.2.7) lib/sidekiq/web.rb:108:in `call'
actionpack (5.0.7.2) lib/action_dispatch/routing/mapper.rb:17:in `block in <class:Constraints>'
actionpack (5.0.7.2) lib/action_dispatch/routing/mapper.rb:46:in `serve'
actionpack (5.0.7.2) lib/action_dispatch/journey/router.rb:39:in `block in serve'
actionpack (5.0.7.2) lib/action_dispatch/journey/router.rb:26:in `each'
actionpack (5.0.7.2) lib/action_dispatch/journey/router.rb:26:in `serve'
actionpack (5.0.7.2) lib/action_dispatch/routing/route_set.rb:727:in `call'

Gems Versions:
ruby - 2.3.7
rails - 5.0.7.2
sidekiq - 5.2.7
rack - master branch

This PR solved issue.

ahmadhasankhan · 2020-01-11T12:12:23Z

I am also facing this issue

NoMethodError (undefined method `transform_keys' for #<ActionDispatch::Request::Session:0x7fe692288f68 not yet loaded>):
  
rack (2.1.0) lib/rack/session/abstract/id.rb:212:in `stringify_keys'
rack (2.1.0) lib/rack/session/abstract/id.rb:148:in `update'
rack (2.1.0) lib/rack/session/abstract/id.rb:317:in `prepare_session'
rack (2.1.0) lib/rack/session/abstract/id.rb:276:in `context'
rack (2.1.0) lib/rack/session/abstract/id.rb:271:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
rack (2.1.0) lib/rack/urlmap.rb:77:in `block in call'
rack (2.1.0) lib/rack/urlmap.rb:61:in `each'
rack (2.1.0) lib/rack/urlmap.rb:61:in `call'
rack (2.1.0) lib/rack/builder.rb:176:in `call'
rollbar (2.23.1) lib/rollbar/middleware/rack/builder.rb:16:in `block in call_with_rollbar'
rollbar (2.23.1) lib/rollbar.rb:145:in `scoped'
rollbar (2.23.1) lib/rollbar/middleware/rack/builder.rb:14:in `call_with_rollbar'
sidekiq (6.0.4) lib/sidekiq/web.rb:104:in `call'
sidekiq (6.0.4) lib/sidekiq/web.rb:109:in `call'
actionpack (5.0.7.2) lib/action_dispatch/routing/mapper.rb:17:in `block in <class:Constraints>'
actionpack (5.0.7.2) lib/action_dispatch/routing/mapper.rb:46:in `serve'
actionpack (5.0.7.2) lib/action_dispatch/journey/router.rb:39:in `block in serve'
actionpack (5.0.7.2) lib/action_dispatch/journey/router.rb:26:in `each'
actionpack (5.0.7.2) lib/action_dispatch/journey/router.rb:26:in `serve'
actionpack (5.0.7.2) lib/action_dispatch/routing/route_set.rb:727:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/rack/agent_hooks.rb:30:in `traced_call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/rack/browser_monitoring.rb:32:in `traced_call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
scout_apm (2.6.6) lib/scout_apm/instant/middleware.rb:53:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
scout_apm (2.6.6) lib/scout_apm/middleware.rb:20:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
warden (1.2.8) lib/warden/manager.rb:36:in `block in call'
warden (1.2.8) lib/warden/manager.rb:34:in `catch'
warden (1.2.8) lib/warden/manager.rb:34:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
rack (2.1.0) lib/rack/etag.rb:27:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
rack (2.1.0) lib/rack/conditional_get.rb:27:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
rack (2.1.0) lib/rack/head.rb:14:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
rack (2.1.0) lib/rack/session/abstract/id.rb:277:in `context'
rack (2.1.0) lib/rack/session/abstract/id.rb:271:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
actionpack (5.0.7.2) lib/action_dispatch/middleware/cookies.rb:613:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
activerecord (5.0.7.2) lib/active_record/migration.rb:553:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
actionpack (5.0.7.2) lib/action_dispatch/middleware/callbacks.rb:38:in `block in call'
activesupport (5.0.7.2) lib/active_support/callbacks.rb:97:in `__run_callbacks__'
activesupport (5.0.7.2) lib/active_support/callbacks.rb:750:in `_run_call_callbacks'
activesupport (5.0.7.2) lib/active_support/callbacks.rb:90:in `run_callbacks'
actionpack (5.0.7.2) lib/action_dispatch/middleware/callbacks.rb:36:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
actionpack (5.0.7.2) lib/action_dispatch/middleware/executor.rb:12:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
actionpack (5.0.7.2) lib/action_dispatch/middleware/remote_ip.rb:79:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
rollbar (2.23.1) lib/rollbar/middleware/rails/rollbar.rb:25:in `block in call'
rollbar (2.23.1) lib/rollbar.rb:145:in `scoped'
rollbar (2.23.1) lib/rollbar/middleware/rails/rollbar.rb:22:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
actionpack (5.0.7.2) lib/action_dispatch/middleware/debug_exceptions.rb:49:in `call'
rollbar (2.23.1) lib/rollbar/middleware/rails/show_exceptions.rb:22:in `call_with_rollbar'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
web-console (3.7.0) lib/web_console/middleware.rb:135:in `call_app'
web-console (3.7.0) lib/web_console/middleware.rb:30:in `block in call'
web-console (3.7.0) lib/web_console/middleware.rb:20:in `catch'
web-console (3.7.0) lib/web_console/middleware.rb:20:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
actionpack (5.0.7.2) lib/action_dispatch/middleware/show_exceptions.rb:31:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
railties (5.0.7.2) lib/rails/rack/logger.rb:36:in `call_app'
railties (5.0.7.2) lib/rails/rack/logger.rb:24:in `block in call'
activesupport (5.0.7.2) lib/active_support/tagged_logging.rb:69:in `block in tagged'
activesupport (5.0.7.2) lib/active_support/tagged_logging.rb:26:in `tagged'
activesupport (5.0.7.2) lib/active_support/tagged_logging.rb:69:in `tagged'
railties (5.0.7.2) lib/rails/rack/logger.rb:24:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
sprockets-rails (3.2.1) lib/sprockets/rails/quiet_assets.rb:13:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
rack-timeout (0.6.0) lib/rack/timeout/core.rb:151:in `block in call'
rack-timeout (0.6.0) lib/rack/timeout/support/timeout.rb:19:in `timeout'
rack-timeout (0.6.0) lib/rack/timeout/core.rb:150:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
actionpack (5.0.7.2) lib/action_dispatch/middleware/request_id.rb:24:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
rack (2.1.0) lib/rack/method_override.rb:24:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
rack (2.1.0) lib/rack/runtime.rb:24:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
rack-timeout (0.6.0) lib/rack/timeout/core.rb:151:in `block in call'
rack-timeout (0.6.0) lib/rack/timeout/support/timeout.rb:19:in `timeout'
rack-timeout (0.6.0) lib/rack/timeout/core.rb:150:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
activesupport (5.0.7.2) lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
actionpack (5.0.7.2) lib/action_dispatch/middleware/executor.rb:12:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
actionpack (5.0.7.2) lib/action_dispatch/middleware/static.rb:136:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
rack (2.1.0) lib/rack/sendfile.rb:113:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
railties (5.0.7.2) lib/rails/engine.rb:522:in `call'
newrelic_rpm (6.8.0.360) lib/new_relic/agent/instrumentation/middleware_tracing.rb:99:in `call'
puma (3.8.2) lib/puma/configuration.rb:224:in `call'
puma (3.8.2) lib/puma/server.rb:600:in `handle_request'
puma (3.8.2) lib/puma/server.rb:435:in `process_client'
puma (3.8.2) lib/puma/server.rb:299:in `block in run'
puma (3.8.2) lib/puma/thread_pool.rb:120:in `block in spawn_thread'

ioquatix · 2020-01-11T20:07:27Z

What is the value of other in the failing case?

Do we prefer to_h or to_hash?

cc @tenderlove @rafaelfranca

ahorek · 2020-01-11T21:27:41Z

in my opinion, #1401 and #1391 should be reverted

adding #to_hash will fix the issue, but the original performance improvement for hash arguments is gone
Rack::Session::Abstract::SessionHash is actually 40% slower
and ActionDispatch::Request::Session is broken

ioquatix · 2020-01-11T21:31:48Z

@ahorek I don't disagree with you.

I can merge this, and then can you make a follow up PR to improve both performance and spec coverage on the downstream requirements? We can get it out in 2.2.0

ahorek · 2020-01-11T21:41:19Z

yes, I think it's ok to merge.

after this PR, the change in #1401 should be reverted anyway, because
Rack::Session::Abstract::SessionHash does respond #to_hash and the custom #transform_keys method is no longer necessary

ioquatix · 2020-01-11T21:46:34Z

Can you make a PR to revert #1401.

kapso · 2020-01-14T00:34:55Z

This still seems to be an issue for me with Rack v2.1.1

PikachuEXE · 2020-01-14T01:10:15Z

@kapso The revert of #1401 is not included in 2.1.1

Rim-777 · 2020-01-14T16:11:12Z

Hello, I have the same issue with Rack v2.1.1, could anyone please give me a hint what need I do to solve it?

mati0090 · 2020-01-14T16:39:35Z

In your Gemfile use following line as temporary solution:
gem 'rack', github: 'rack/rack', ref: 'f690bb71425aa31d7b9b3113829af773950d8ab5'

garside · 2020-01-15T06:13:48Z

If you need to deploy this to heroku, use this format in the gemfile instead or your build will fail with private key errors.

gem 'rack', github: 'rack/rack', :ref => 'f690bb71425aa31d7b9b3113829af773950d8ab5'

Rim-777 · 2020-01-15T09:28:51Z

@mati0090 Thank you, it helped.
@garside Thank you too

jjstafford · 2020-01-15T17:12:23Z

@garside that worked great. Hopefully this is merged soon....

saiqulhaq · 2020-01-16T05:16:01Z

can we have v2.1.1.1 version to release this?

…ile we wait for a gem release. rack/rack#1428

* Update Rack gem to reference a specific Github commit to fix a bug while we wait for a gem release. rack/rack#1428

chongfai13 · 2020-01-17T07:59:23Z

In your Gemfile use following line as temporary solution:
gem 'rack', github: 'rack/rack', ref: 'f690bb71425aa31d7b9b3113829af773950d8ab5'

I encountered this error after adding

Could not find gem 'browserify-:q!ils' in any of the gem sources listed in your Gemfile or in gems cached in vendor/cache.

saiqulhaq · 2020-01-17T08:46:29Z

In your Gemfile use following line as temporary solution:
gem 'rack', github: 'rack/rack', ref: 'f690bb71425aa31d7b9b3113829af773950d8ab5'

I encountered this error after adding

Could not find gem 'browserify-:q!ils' in any of the gem sources listed in your Gemfile or in gems cached in vendor/cache.

your issue is not related to rack
this is my Gemfile

I updated it 2 hours ago without any problem after bundle install

chongfai13 · 2020-01-17T09:23:44Z

In your Gemfile use following line as temporary solution:
gem 'rack', github: 'rack/rack', ref: 'f690bb71425aa31d7b9b3113829af773950d8ab5'

I encountered this error after adding
Could not find gem 'browserify-:q!ils' in any of the gem sources listed in your Gemfile or in gems cached in vendor/cache.

your issue is not related to rack
this is my Gemfile

I updated it 2 hours ago without any problem after bundle install

It works! Terima Kasih banyak banyak

ioquatix · 2020-01-17T19:44:50Z

@tenderlove should we backport this and cut a v2.1.2 release or wait until a v2.2.0 release?

natematykiewicz · 2020-01-18T05:11:35Z

I’d love a release. My Sidekiq admin page is busted and it took my a while to figure out what the problem was.

estebanbouza · 2020-01-18T23:34:38Z

This approach works on development:

gem 'rack', github: 'rack/rack', ref: 'f690bb71425aa31d7b9b3113829af773950d8ab5'

But in Production, I get:

Step #1 - "docker-build": Step 10/11 : RUN cd /app && RAILS_ENV=production SECRET_KEY_BASE=xxx rails assets:precompile
Step #1 - "docker-build": ---> Running in 57e0841136
Step #1 - "docker-build": /usr/local/lib/ruby/2.6.0/rubygems/dependency.rb:311:in `to_specs': Could not find 'rack' (~> 2.0, >= 2.0.8) among 228 total gem(s) (Gem::MissingSpecError)
Step #1 - "docker-build": Checked in 'GEM_PATH=/xxx/.gem/ruby/2.6.0:/usr/local/lib/ruby/gems/2.6.0:/usr/local/bundle', execute `gem env` for more information
Step #1 - "docker-build": from /usr/local/lib/ruby/2.6.0/rubygems/specification.rb:1449:in `block in activate_dependencies'

Which seems to be the expected behavior based on bundler doc

Because RubyGems lacks the ability to handle gems from git, any gems installed from a git repository will not show up in gem list.

Any clue? A new release would be appreciated otherwise.

shleeable · 2020-01-20T17:36:54Z

ETA til 2.1.2?

springerigor · 2020-01-21T08:51:14Z

If you are waiting for the 2.1.2 you can temporarily monkey patch rack:

Fo Rails projects you can create e.g. config/initializers/rack_monkey_path.rb file:

# Monkey patch `stringify_keys` to make rack 2.1.1 compatible with Sidekiq UI Admin panel.
# Should be removed when 2.1.2 is released.
# https://github.com/rack/rack/pull/1428
module Rack
  module Session
    module Abstract
      class SessionHash
        private

        def stringify_keys(other)
          other.to_hash.transform_keys(&:to_s)
        end
      end
    end
  end
end

Rim-777 · 2020-01-21T11:28:08Z

If you need to deploy this to heroku, use this format in the gemfile instead or your build will fail with private key errors.
gem 'rack', github: 'rack/rack', :ref => 'f690bb71425aa31d7b9b3113829af773950d8ab5'

@garside I got some problems with deploy on AWS. is there an appropriate ref hash for that?

rack/rack#1428

jbilbo · 2020-01-29T11:16:20Z

v2.1.2 has been released. Now you can

bundle update rack

and make sure you use v2.1.2 or higher to avoid this issue.

ArturT · 2020-01-29T20:11:56Z

If you updated your app to rack 2.1.2 and you see a blank page for Sidekiq Web UI then there is an issue in Sidekiq repo for it sidekiq/sidekiq#4440

rack/rack#1428 has now been merged and released, so we no longer need to pin to a specific commit.

… makes it into the next release

Downgrades rack on account of rack/rack#1428

Fix: Add to_hash to wrap Hash and Session classes

68e2ab2

oleh-demyanyuk changed the title ~~[WIP] Fix: Add to_hash to wrap Hash and Session classes on stringify_keys~~ Fix: Add to_hash to wrap Hash and Session classes on stringify_keys Dec 16, 2019

ioquatix merged commit 8659d9f into rack:master Jan 11, 2020

ahorek mentioned this pull request Jan 11, 2020

Revert #transform_keys #1477

Merged

dentarg mentioned this pull request Jan 11, 2020

rack 2.0.8 breaking change sinatra/sinatra#1589

Closed

Obsiye mentioned this pull request Jan 15, 2020

Bump i18n-tasks from 0.9.29 to 0.9.30 ministryofjustice/laa-apply-for-legal-aid#1172

Merged

jholton mentioned this pull request Jan 16, 2020

update Rack to fix bug that prevents Sidekiq admin from running department-of-veterans-affairs/va.gov-team#4928

Closed

jholton added a commit to department-of-veterans-affairs/vets-api that referenced this pull request Jan 16, 2020

Update Rack gem to reference a specific Github commit to fix a bug wh…

4494b58

…ile we wait for a gem release. rack/rack#1428

jholton mentioned this pull request Jan 16, 2020

Update Rack gem department-of-veterans-affairs/vets-api#3796

Merged

7 tasks

jholton pushed a commit to department-of-veterans-affairs/vets-api that referenced this pull request Jan 16, 2020

Update Rack gem (#3796)

0d055b3

* Update Rack gem to reference a specific Github commit to fix a bug while we wait for a gem release. rack/rack#1428

ioquatix modified the milestones: v2.1.2, v2.2.0 Jan 17, 2020

ioquatix modified the milestones: v2.2.0, v2.1.2 Jan 17, 2020

BenLubar mentioned this pull request Jan 18, 2020

rack 2.1 breaks sidekiq mastodon/mastodon#12880

Closed

This was referenced Jan 20, 2020

Bump gds-api-adapters from 63.2.0 to 63.3.0 alphagov/collections-publisher#908

Merged

Bump govuk_publishing_components from 21.19.0 to 21.20.0 alphagov/collections-publisher#907

Closed

slorek mentioned this pull request Jan 20, 2020

Fix Sidekiq web not working with latest Rack versions OfficeForProductSafetyAndStandards/product-safety-database#191

Merged

9 tasks

natematykiewicz mentioned this pull request Jan 21, 2020

Sidekiq UI broken moving between 2.0.8 and 2.1.1 #1504

Closed

mstruve mentioned this pull request Jan 21, 2020

Apply Monkey Patch To Attempt To Fix Sidekiq Admin UI forem/forem#5634

Merged

2 tasks

camallen added a commit to zooniverse/caesar that referenced this pull request Jan 22, 2020

downgrade rack gem

5bc0a44

rack/rack#1428

camallen mentioned this pull request Jan 22, 2020

downgrade rack gem zooniverse/caesar#1074

Merged

camallen added a commit to zooniverse/caesar that referenced this pull request Jan 22, 2020

downgrade rack gem (#1074)

0dc4a3d

rack/rack#1428

emmabeynon mentioned this pull request Jan 29, 2020

Bump govuk_app_config from 2.0.1 to 2.0.2 alphagov/collections-publisher#910

Merged

frankieroberto added a commit to OfficeForProductSafetyAndStandards/product-safety-database that referenced this pull request Jan 31, 2020

switch rack gem to use released 2.1.2 version

a9c007a

rack/rack#1428 has now been merged and released, so we no longer need to pin to a specific commit.

frankieroberto mentioned this pull request Jan 31, 2020

switch rack gem to use released 2.1.2 version OfficeForProductSafetyAndStandards/product-safety-database#248

Merged

rhymes mentioned this pull request Jun 18, 2020

Rails 6: enable zeitwerk autoloader forem/forem#8766

Merged

8 tasks

rtucker pushed a commit to vulpineclub/mastodon that referenced this pull request Jan 7, 2021

update rack to 2.2.0@f690bb714 until github.com/rack/rack/pull/1428…

257b33c

… makes it into the next release

IvakhOleksii pushed a commit to IvakhOleksii/Ruby-on-Rails-sales that referenced this pull request Nov 19, 2022

Downgrades rack on account of rack/rack#1428

ab481c9

IvakhOleksii pushed a commit to IvakhOleksii/Ruby-on-Rails-sales that referenced this pull request Nov 19, 2022

Merge tag 'downgrade-rack' into develop

2aad9c1

Downgrades rack on account of rack/rack#1428

IvakhOleksii added a commit to IvakhOleksii/Ruby-on-Rails-sales that referenced this pull request May 29, 2023

Downgrades rack on account of rack/rack#1428

c64f864

IvakhOleksii added a commit to IvakhOleksii/Ruby-on-Rails-sales that referenced this pull request May 29, 2023

Merge tag 'downgrade-rack' into develop

f0cd8be

Downgrades rack on account of rack/rack#1428

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Add `to_hash` to wrap Hash and Session classes on `stringify_keys` #1428

Fix: Add `to_hash` to wrap Hash and Session classes on `stringify_keys` #1428

oleh-demyanyuk commented Dec 16, 2019 •

edited

ahmadhasankhan commented Jan 11, 2020

ioquatix commented Jan 11, 2020

ahorek commented Jan 11, 2020

ioquatix commented Jan 11, 2020

ahorek commented Jan 11, 2020

ioquatix commented Jan 11, 2020 •

edited

kapso commented Jan 14, 2020

PikachuEXE commented Jan 14, 2020

Rim-777 commented Jan 14, 2020

mati0090 commented Jan 14, 2020 •

edited

garside commented Jan 15, 2020

Rim-777 commented Jan 15, 2020

jjstafford commented Jan 15, 2020

saiqulhaq commented Jan 16, 2020

chongfai13 commented Jan 17, 2020

saiqulhaq commented Jan 17, 2020

chongfai13 commented Jan 17, 2020

ioquatix commented Jan 17, 2020

natematykiewicz commented Jan 18, 2020

estebanbouza commented Jan 18, 2020

shleeable commented Jan 20, 2020

springerigor commented Jan 21, 2020

Rim-777 commented Jan 21, 2020 •

edited

jbilbo commented Jan 29, 2020

ArturT commented Jan 29, 2020

Fix: Add to_hash to wrap Hash and Session classes on stringify_keys #1428

Fix: Add to_hash to wrap Hash and Session classes on stringify_keys #1428

Conversation

oleh-demyanyuk commented Dec 16, 2019 • edited

ahmadhasankhan commented Jan 11, 2020

ioquatix commented Jan 11, 2020

ahorek commented Jan 11, 2020

ioquatix commented Jan 11, 2020

ahorek commented Jan 11, 2020

ioquatix commented Jan 11, 2020 • edited

kapso commented Jan 14, 2020

PikachuEXE commented Jan 14, 2020

Rim-777 commented Jan 14, 2020

mati0090 commented Jan 14, 2020 • edited

garside commented Jan 15, 2020

Rim-777 commented Jan 15, 2020

jjstafford commented Jan 15, 2020

saiqulhaq commented Jan 16, 2020

chongfai13 commented Jan 17, 2020

saiqulhaq commented Jan 17, 2020

chongfai13 commented Jan 17, 2020

ioquatix commented Jan 17, 2020

natematykiewicz commented Jan 18, 2020

estebanbouza commented Jan 18, 2020

shleeable commented Jan 20, 2020

springerigor commented Jan 21, 2020

Rim-777 commented Jan 21, 2020 • edited

jbilbo commented Jan 29, 2020

ArturT commented Jan 29, 2020

Fix: Add `to_hash` to wrap Hash and Session classes on `stringify_keys` #1428

Fix: Add `to_hash` to wrap Hash and Session classes on `stringify_keys` #1428

oleh-demyanyuk commented Dec 16, 2019 •

edited

ioquatix commented Jan 11, 2020 •

edited

mati0090 commented Jan 14, 2020 •

edited

Rim-777 commented Jan 21, 2020 •

edited