Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enclose IPv6 address in X-Forwarded-Host in brackets #1213

Closed
wants to merge 2 commits into from
Closed

Enclose IPv6 address in X-Forwarded-Host in brackets #1213

wants to merge 2 commits into from

Commits on Nov 1, 2017

  1. Add failing test for IPv6 address in X-Forwarded-Host

    @mwpastore
    mwpastore committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    7def23e View commit details
    Browse the repository at this point in the history

  2. Enclose IPv6 address in X-Forwarded-Host in brackets 

    Prevent Rack::Request#host from stripping off last hextet of IPv6
address in X-Forwarded-Host returned by Rack::Request#host_with_port
by enclosing the address in brackets.

IPv6 addresses in the HTTP_HOST, SERVER_NAME, and SERVER_ADDR CGI
variables will (should) always be enclosed in brackets.
    @mwpastore
    mwpastore committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    d1f6b41 View commit details
    Browse the repository at this point in the history