Ensure full match. Fixes #1590.

rack · Feb 10, 2020 · 784dcd2 · 784dcd2
1 parent 3d7a634
commit 784dcd2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/rack/request.rb b/lib/rack/request.rb
@@ -598,7 +598,7 @@ def split_header(value)
         value ? value.strip.split(/[,\s]+/) : []
       end
 
-      AUTHORITY = /
+      AUTHORITY = /^
         # The host:
         (?<host>
           # An IPv6 address:
@@ -612,7 +612,7 @@ def split_header(value)
         )
         # The optional port:
         (:(?<port>\d+))?
-      /x
+      $/x
 
       private_constant :AUTHORITY
 

diff --git a/test/spec_request.rb b/test/spec_request.rb
@@ -116,6 +116,11 @@ class RackRequestTest < Minitest::Spec
     req.host.must_equal "www2.example.org"
     req.hostname.must_equal "www2.example.org"
 
+    req = make_request \
+      Rack::MockRequest.env_for("/", "HTTP_HOST" => "123foo.example.com")
+    req.host.must_equal "123foo.example.com"
+    req.hostname.must_equal "123foo.example.com"
+
     req = make_request \
       Rack::MockRequest.env_for("/", "SERVER_NAME" => "example.org", "SERVER_PORT" => "9292")
     req.host.must_equal "example.org"