Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add
Rack::ErrorHandler
for generic error handling.
- Loading branch information
Showing
3 changed files
with
90 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
require_relative 'constants' | ||
|
||
module Rack | ||
class ErrorHandler | ||
def initialize(app) | ||
@app = app | ||
end | ||
|
||
def log_error(env, error) | ||
env[RACK_ERRORS].puts(error.full_message) | ||
end | ||
|
||
def bad_request(error) | ||
[400, {}, ["Bad Request: #{error.class}"]] | ||
end | ||
|
||
def internal_server_error(error) | ||
[500, {}, ["Internal Server Error: #{error.class}"]] | ||
end | ||
|
||
def call(env) | ||
@app.call(env) | ||
rescue BadRequest => error | ||
log_error(env, error) | ||
return bad_request(error) | ||
rescue ScriptError, StandardError => error | ||
log_error(env, error) | ||
return internal_server_error(error) | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
# frozen_string_literal: true | ||
|
||
require_relative 'helper' | ||
require 'tempfile' | ||
require 'fileutils' | ||
|
||
separate_testing do | ||
require_relative '../lib/rack/error_handler' | ||
require_relative '../lib/rack/lint' | ||
require_relative '../lib/rack/mock_request' | ||
end | ||
|
||
describe Rack::ErrorHandler do | ||
it "catches bad requests as 400 Bad Request" do | ||
error = Class.new(StandardError) | ||
error.include(Rack::BadRequest) | ||
|
||
app = lambda do |env| | ||
raise error, "b00m" | ||
end | ||
|
||
middleware = Rack::Lint.new(Rack::ErrorHandler.new(app)) | ||
response = middleware.call(Rack::MockRequest.env_for("/")) | ||
|
||
response[0].must_equal 400 | ||
response[2].to_ary.must_equal ["Bad Request: #{error}"] | ||
end | ||
|
||
it "catches standard errors as 500 Internal Server Error" do | ||
error = Class.new(StandardError) | ||
|
||
app = lambda do |env| | ||
raise error, "b00m" | ||
end | ||
|
||
middleware = Rack::Lint.new(Rack::ErrorHandler.new(app)) | ||
response = middleware.call(Rack::MockRequest.env_for("/")) | ||
|
||
response[0].must_equal 500 | ||
response[2].to_ary.must_equal ["Internal Server Error: #{error}"] | ||
end | ||
|
||
it "logs errors to the rack.errors stream" do | ||
app = lambda do |env| | ||
raise "b00m" | ||
end | ||
|
||
middleware = Rack::Lint.new(Rack::ErrorHandler.new(app)) | ||
errors = StringIO.new | ||
response = middleware.call(Rack::MockRequest.env_for("/", "rack.errors" => errors)) | ||
|
||
errors.string.must_match(/RuntimeError/) | ||
errors.string.must_match(/b00m/) | ||
|
||
response[0].must_equal 500 | ||
response[2].to_ary.must_equal ["Internal Server Error: RuntimeError"] | ||
end | ||
end |