Add Ruby 2.6

[tarebyte]

No description provided.

[dennissivia]

@tarebyte thanks for your contribution. As far as I understood, there was at least one significant security flaw in ruby 2.6.0. Could you update the PR to use 2.6.1 instead?
When that is done and when CI works, we are glad to merge.

[tarebyte]

Gah sorry @scepticulous for some reason I thought I opened this on my fork 🤦‍♂️ so apologies for the lack of description or follow up.

I can update to the latest ruby 2.6 since I'm already here 😅

[junaruga]

Bundler latest version requires Ruby >= 2.3.
https://rubygems.org/gems/bundler/versions/2.0.1
Maybe we can update bundler to the latest version conditionally.

Also this error.

https://travis-ci.org/rack-test/rack-test/jobs/478857681
TypeError:
can't dup NilClass

The reason is maybe below code is okay except Ruby 2.3.
But on Ruby 2.3, below code becomes the TypeError.

On Ruby 2.5 irb

irb(main):001:0> nil.dup
=> nil

On Ruby 2.3 irb

irb(main):001:0> nil.dup
TypeError: can't dup NilClass
	from (irb):1:in `dup'
	from (irb):1
	from /usr/local/ruby-2.3.1/bin/irb:11:in `<main>'

[dennissivia]

@junaruga I wonder if we should fix the fact that we are using env with a value of nil. Maybe by replacing it with a stubbed value. This would als make the tests more realistic.
What do you think?

[junaruga]

@scepticulous let me think it.
By the way, I think we can run Travis CI as daily cron mode too.
Seeing the history of the build, the last build is 5 month ago.
That's not good :<

[dennissivia]

@junaruga I fully agree on the cron mode. Can you take care of that?
Regarding the test adjustments. let me know if you opt for it. In that case I could update the PR to add the adjustment in order to fix the nil.dup issue.

[junaruga]

@scepticulous for the cron mode, adding the notification to freenode server #rack-test channel might be better at least than current situation.
Though I am not sure I can care, I am going to join the irc channel if the channel is created.

There are 2 cases.

https://github.com/socketry/nio4r/blob/master/.travis.yml

notifications:
  irc: "irc.freenode.org#celluloid"

https://github.com/sass/sass/blob/3.5.6/.travis.yml#L32

[junaruga]

@scepticulous

Regarding the test adjustments. let me know if you opt for it. In that case I could update the PR to add the adjustment in order to fix the nil.dup issue.

I found the reason of the issue. This is because of sinatra latest version 2.0.5. This issue does not happen on sinatra 2.0.4. I think we can wait next version of the sinatra or just pin sinatra adding gem 'sinatra', '2.0.4' to Gemfile.

I opened the ticket.
#243

[dennissivia]

@tarebyte yes, please push the change to 2.6.1 instead of 2.6.0 and we can merge it.
The build failures are already addressed in other issues and PRs, so we would be glad to merge your PR as soon as its 2.6.1

[dennissivia]

I am fine with merging. What about you @perlun @junaruga

[junaruga]

@scepticulous yeah, I am okay.

[dennissivia]

@junaruga can you merge this dispite the failing jenkins check?
I guess we should just merge the fixes that make CI pass again asap so that we are able to activate travis as a requirement again. otherwise we are not able to accept contributions.

[junaruga]

@scepticulous

guess we should just merge the fixes that make CI pass again asap so that we are able to activate travis as a requirement again.

Yeah I agree to make CI pass again asap.
Let's merge another PR too.

[junaruga]

@tarebyte Thanks Mark!