Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert response status to Integer with to_i method call #177

Closed

Conversation

andrykonchin
Copy link
Collaborator

The specification require response status to have only method to_i to convert it to Integer. Some middleware treat it as Integer itself.

Here was added explicit conversion to Integer.

Changes:

  • fixed Rack::JSONP
  • fixed Rack::RelativeRedirect
  • fixed Rack::ResponseCache
  • fixed Rack::TryStatic

@ioquatix
Copy link
Member

ioquatix commented May 5, 2020

@jeremyevans any thoughts on this? Should status actually be required to be an integer?

@jeremyevans
Copy link
Contributor

This depends on the decision we make in rack/rack#1644. Under current SPEC, yes, to_i would be required for correctness. However, I think we should change SPEC. Non-integer status doesn't add value, IMO.

@rkh
Copy link
Member

rkh commented Apr 20, 2021

Made obsolete by rack/rack#1662.

@rkh rkh closed this Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants