Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: freeze time in more specs #643

Merged
merged 4 commits into from
Jan 10, 2024
Merged

ci: freeze time in more specs #643

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f79cb2d
ci: freeze time in more specs
santib Dec 13, 2023
e7e0a05
Merge branch 'main' into freeze-time-2
grzuy Dec 26, 2023
7a45a3f
Introduce within_same_period helper method
santib Dec 27, 2023
fdc0fb4
Merge branch 'main' into freeze-time-2
grzuy Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
52 changes: 30 additions & 22 deletions spec/support/cache_store_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# frozen_string_literal: true

require "timecop"

class Minitest::Spec
def self.it_works_for_cache_backed_features(options)
fetch_from_store = options.fetch(:fetch_from_store)
Expand All @@ -9,11 +11,13 @@ def self.it_works_for_cache_backed_features(options)
request.ip
end

get "/", {}, "REMOTE_ADDR" => "1.2.3.4"
assert_equal 200, last_response.status
Timecop.freeze do
grzuy marked this conversation as resolved.
Show resolved Hide resolved
get "/", {}, "REMOTE_ADDR" => "1.2.3.4"
assert_equal 200, last_response.status

get "/", {}, "REMOTE_ADDR" => "1.2.3.4"
assert_equal 429, last_response.status
get "/", {}, "REMOTE_ADDR" => "1.2.3.4"
assert_equal 429, last_response.status
end
end

it "works for fail2ban" do
Expand All @@ -23,17 +27,19 @@ def self.it_works_for_cache_backed_features(options)
end
end

get "/"
assert_equal 200, last_response.status
Timecop.freeze do
get "/"
assert_equal 200, last_response.status

get "/private-place"
assert_equal 403, last_response.status
get "/private-place"
assert_equal 403, last_response.status

get "/private-place"
assert_equal 403, last_response.status
get "/private-place"
assert_equal 403, last_response.status

get "/"
assert_equal 403, last_response.status
get "/"
assert_equal 403, last_response.status
end
end

it "works for allow2ban" do
Expand All @@ -43,20 +49,22 @@ def self.it_works_for_cache_backed_features(options)
end
end

get "/"
assert_equal 200, last_response.status
Timecop.freeze do
get "/"
assert_equal 200, last_response.status

get "/scarce-resource"
assert_equal 200, last_response.status
get "/scarce-resource"
assert_equal 200, last_response.status

get "/scarce-resource"
assert_equal 200, last_response.status
get "/scarce-resource"
assert_equal 200, last_response.status

get "/scarce-resource"
assert_equal 403, last_response.status
get "/scarce-resource"
assert_equal 403, last_response.status

get "/"
assert_equal 403, last_response.status
get "/"
assert_equal 403, last_response.status
end
end

it "doesn't leak keys" do
Expand Down