rabbit: Stop Khepri store and Ra systems in stop/1
#10372
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
changed the title
stop/1
dumbbell
force-pushed
the
stop-khepri-store-and-ra-systems
branch
5 times, most recently
from
4d8fa17
to
e030196
Compare
[Why] The Khepri store and the coordinators are Ra servers and thus run under the Ra supervision tree. Therefore we need to explicitly stop them otherwise they will continue to run after `rabbit` was stopped. Likewise, the Ra systems are under the Ra supervision tree. We also need to stop them. [How] We need to stop Ra servers and Ra systems that we started but live under the Ra supervision tree. The order is important: 1. The `quorum_queues` Ra system because it may host Ra servers that depend on Khepri. 2. The stream coordinator because it depends on Khepri. 3. The Khepri store; it could be stopped automatically with the termination of the underlying Ra system, but Khepri needs to do some cleanup too. 4. The remaining Ra systems.
[Why] This function blindly relied on the fact that the Ra `coordination` system was not stopped by `rabbit` when it stopped. That Ra system is finally correctly stopped in the parent commit. This breaks this function and it must be adapted to work with the Ra system stopped. This is even safer because the function deletes the Ra system directory as its last step. [How] The Ra system data directory is queried from RabbitMQ configuration instead of the running Ra system. We add a couple assertions to ensure the conditions are the ones we expect.
dumbbell
force-pushed
the
stop-khepri-store-and-ra-systems
branch
from
e030196
to
ab671b7
Compare
|
Stopping Ra systems and servers with the One of them is the Ideally, we want to redesign the operations that require a Therefore this pull request is put on hold until we come back to it after Khepri is the only database we use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The Khepri store and the coordinators are Ra servers and thus run under the Ra supervision tree. Therefore we need to explicitly stop them otherwise they will continue to run after
rabbitwas stopped.Likewise, the Ra systems are under the Ra supervision tree. We also need to stop them.
How
We need to stop Ra servers and Ra systems that we started but live under
the Ra supervision tree. The order is important:
quorum_queuesRa system because it may host Ra servers that depend on Khepri.