Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to k8s api 1.23 #965

Merged
merged 3 commits into from
Feb 18, 2022
Merged

Bump to k8s api 1.23 #965

merged 3 commits into from
Feb 18, 2022

Conversation

ChunyiLyu
Copy link
Contributor

@ChunyiLyu ChunyiLyu commented Feb 17, 2022

This closes #

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

  • there are some types changes from covev1. However their json markers
    have not changed so this is not a user facing update.
  • have tested in kubernetes 1.19 and system tests all passed
  • have tested in kubernetes 1.19 and 1.21 and this update does does not trigger pod rolling upgrade
  • related PR in messaging topology operator: Bump to k8s api 1.23 messaging-topology-operator#304

Additional Context

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

- types changes from covev1, however json markers
have not changed and this is not a user facing update
@ChunyiLyu
Copy link
Contributor Author

Bumped golang version from 1.16 - 1.17 in github action because controller-gen is not compatible with golang 1.16 runtime. Related issue: kubernetes-sigs/controller-tools#643

We are already building all operators in 1.17 so this only changes the golang version in our github action environment.

Copy link
Collaborator

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you figure the solution to the go-logr change!

Copy link
Contributor

@coro coro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you also bump this so our docs point at the latest API reference pls?

kubernetesVersion: "1.22"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants