Bump gopkg.in/ini.v1 from 1.66.5 to 1.66.6 #1050
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [gopkg.in/ini.v1](https://github.com/go-ini/ini) from 1.66.5 to 1.66.6. - [Release notes](https://github.com/go-ini/ini/releases) - [Commits](go-ini/ini@v1.66.5...v1.66.6) --- updated-dependencies: - dependency-name: gopkg.in/ini.v1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
|
We don't think this is a simple merge - this has broken our unit tests as a result of this merge. |
- instead of matching on the error msgs exactly, assert on error occurring is enough for us
|
A returned error msg has changed in new version of ini. We were matching on the exact error string. Instead of matching on the error string, assert on error occurring is enough for the test case. |
There was a problem hiding this comment.
I think it's ok to not match a specific error. We are relying on a 3rd party library and we can consider this sort of a contract. From our point of view, we only care that it errors. The specific error should not be too relevant. One could argue that the call may fail for the wrong reasons, and our test would still pass; however, in that scenario, the library would be breaking the contract. In any case, the expected outcome is an error.
* Bump gopkg.in/ini.v1 from 1.66.5 to 1.66.6 Bumps [gopkg.in/ini.v1](https://github.com/go-ini/ini) from 1.66.5 to 1.66.6. - [Release notes](https://github.com/go-ini/ini/releases) - [Commits](go-ini/ini@v1.66.5...v1.66.6) --- updated-dependencies: - dependency-name: gopkg.in/ini.v1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Error msgs changed in ini library - instead of matching on the error msgs exactly, assert on error occurring is enough for us Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chunyi Lyu <clyu@vmware.com>
Bumps gopkg.in/ini.v1 from 1.66.5 to 1.66.6.
Release notes
Sourced from gopkg.in/ini.v1's releases.
Commits
6098d42parser: fix line skipping when key is empty (#323)7c569ccchore: various config updates to CI (#322)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)