Add compatibility for RuboCop v1.38.0 and above #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to rubocop/rubocop#10987 we need to set `ProcessedSource#config` and `ProcessedSource#registry`. Not doing so caused `Lint/MissingCopEnableDirective` and `Lint/RedundantCopDisableDirective` cops to crash.
leoarnold
added a commit
to leoarnold/templatecop
that referenced
this pull request
Jan 9, 2023
When a cop raises an exception, RuboCop will swallow it and tell you to use debug mode if you want to see the backtrace. I needed to add this in order to be able to debug the problems which lead to PR r7kamura#5.
leoarnold
added a commit
to leoarnold/templatecop
that referenced
this pull request
Jan 9, 2023
When a cop raises an exception, RuboCop will swallow it and tell you to use debug mode if you want to see the backtrace. I needed to add this in order to be able to debug the problems which lead to PR r7kamura#5.
r7kamura
requested changes
Jan 9, 2023
There was a problem hiding this comment.
Thanks @leoarnold, I can't accept the changes about Gemfile.lock, but I would like to merge the other points.
| @@ -6,6 +6,7 @@ | |||
| /pkg/ | |||
| /spec/reports/ | |||
| /tmp/ | |||
| Gemfile.lock | |||
There was a problem hiding this comment.
This change is unacceptable.
Bundler recommends in its official documentation that Gemfile.lock be managed by Git, and in fact the rubocop-rails gem and rubocop-rspec gem have various problems by not managing Gemfile.lock with Git. If you want to make sure that it works with the latest version of RuboCop without any problems, I think it would be better to set up a separate workflow to check it.
r7kamura
added a commit
that referenced
this pull request
Jan 9, 2023
r7kamura
pushed a commit
that referenced
this pull request
Jan 9, 2023
When a cop raises an exception, RuboCop will swallow it and tell you to use debug mode if you want to see the backtrace. I needed to add this in order to be able to debug the problems which lead to PR #5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to rubocop/rubocop#10987 we need to set
ProcessedSource#configandProcessedSource#registry.Not doing so caused
Lint/MissingCopEnableDirectiveandLint/RedundantCopDisableDirectivecops to crash.