Skip to content

Commit

Permalink
Merge pull request #37 from r7kamura/feature/factory-bot
Browse files Browse the repository at this point in the history
Remove `Sevencop/FactoryBotCreateList` cop
  • Loading branch information
r7kamura committed Sep 24, 2022
2 parents 612c63b + f64b904 commit 9936f55
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 164 deletions.
19 changes: 0 additions & 19 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,25 +88,6 @@ belongs_to :group, options

This is useful for migration of `config.active_record.belongs_to_required_by_default`.

### Sevencop/FactoryBotCreateList

Finds possible substitutions for `FactoryBot.create_list`.

```ruby
# bad
Array.new(2) do
create(:user)
end

# good
create_list(:user, 2)

# good
Array.new(2) do |i|
create(:user, order: i)
end
```

### Sevencop/HashLiteralOrder

Sort Hash literal entries by key.
Expand Down
6 changes: 0 additions & 6 deletions config/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ Sevencop/BelongsToOptional:
Safe: false
VersionAdded: '0.5'

Sevencop/FactoryBotCreateList:
Description: |
Finds possible substitutions for `FactoryBot.create_list`.
Enabled: false
VersionAdded: '0.10'

Sevencop/HashLiteralOrder:
Description: |
Sort Hash literal entries by key.
Expand Down
95 changes: 0 additions & 95 deletions lib/rubocop/cop/sevencop/factory_bot_create_list.rb

This file was deleted.

1 change: 0 additions & 1 deletion lib/sevencop.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

require_relative 'rubocop/cop/sevencop/autoload_ordered'
require_relative 'rubocop/cop/sevencop/belongs_to_optional'
require_relative 'rubocop/cop/sevencop/factory_bot_create_list'
require_relative 'rubocop/cop/sevencop/hash_literal_order'
require_relative 'rubocop/cop/sevencop/inferred_spec_type'
require_relative 'rubocop/cop/sevencop/method_definition_keyword_arguments_ordered'
Expand Down
43 changes: 0 additions & 43 deletions spec/rubocop/cop/sevencop/factory_bot_create_list_spec.rb

This file was deleted.

0 comments on commit 9936f55

Please sign in to comment.