Implement dark mode #2338
Implement dark mode #2338
Conversation
Copies relevant, recent work from rstudio/bslib kudos to @gadenbuie
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
I'm really glad you saw the bslib PR and started porting this to pkgdown! I had been planning to open an issue with some thoughts and guidance from my experience; instead I've left a few comments in this PR. Feel free to comment here or reach out any time if I can help in any way.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I'm going to leave this PR where it is for a bit — I think to get the CSS right, we need to rethink how the navbar is generated. It looks like our CSS provides a bunch of customisations that we can probably get rid of, and then dark mode gets much simpler. |
|
@jayhesselberth this is your PR so I can't easily request a review, but can you please take a look? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
| @@ -121,12 +136,6 @@ aside { | |||
| } | |||
|
|
|||
| /* table of contents -------------------------------------------------------- */ | |||
| $pkgdown-toc-border-width: 0 !default; | |||
There was a problem hiding this comment.
No evidence that any one has used these: https://github.com/search?q=pkgdown-toc+&type=code
|
I've merged this because I think it's at least 95% there, but please file issues if you spot any problems. |
Opt-in "light switch" to allow the user to switch between light and dark modes. Fixes r-lib#1696. Co-authored-by: Jay Hesselberth <jayhesselberth@jays-imac.ucdenver.pvt> Co-authored-by: Hadley Wickham <h.wickham@gmail.com>
Copies relevant, recent work from rstudio/bslib
kudos to @gadenbuie
related to #1696