spaces_inside_linter ignores trailing comments #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
AshesITR
previously approved these changes
Nov 30, 2020
|
this darn travis thing. going to close this PR & reopen on a dummy branch |
…/lintr into spaces-inside-trailing-comment
Closed
|
@jimhester sorry for the bother... searched around a bit, maybe you could remove travis from branch protection? jazzband/pip-tools#1229 (comment) more instructions here: |
AshesITR
approved these changes
Nov 30, 2020
|
Looks like the build failures actually expose a bugged edge-case: Multiple spaces still cause a lint. |
AshesITR
requested changes
Nov 30, 2020
…/lintr into spaces-inside-trailing-comment
|
good catch; fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #636