Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore DeprecationWarnings raised by pyximport on Python 3.10. #1978

Conversation

hodgestar
Copy link
Contributor

@hodgestar hodgestar commented Aug 18, 2022

Description

  • Ignore DeprecationWarnings raised by pyximport on Python 3.10.
  • Explain (after much digging) how to pass --with-openmp to python -m build.

Related issues or PRs

@hodgestar hodgestar added this to the QuTiP 4.7.1 milestone Aug 18, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.935% when pulling 5333982 on hodgestar:feature/silence-pyximport-relative-error-warning into 82c6704 on qutip:master.

@drew-parsons
Copy link
Contributor

drew-parsons commented Aug 18, 2022

--config-setting="--global-option=--with-openmp" gives a build error (qutip 4.7.0, debian unstable, python 3.10.6):

$ python3.10 -m build --skip-dependency-check --no-isolation --wheel --config-setting="--global-option=--with-openmp"
* Building wheel...
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/pep517/in_process/_in_process.py", line 363, in <module>
    main()
  File "/usr/lib/python3/dist-packages/pep517/in_process/_in_process.py", line 345, in main
    json_out['return_val'] = hook(**hook_input['kwargs'])
  File "/usr/lib/python3/dist-packages/pep517/in_process/_in_process.py", line 261, in build_wheel
    return _build_backend().build_wheel(wheel_directory, config_settings,
  File "/usr/lib/python3/dist-packages/setuptools/build_meta.py", line 230, in build_wheel
    return self._build_with_temp_dir(['bdist_wheel'], '.whl',
  File "/usr/lib/python3/dist-packages/setuptools/build_meta.py", line 211, in _build_with_temp_dir
    sys.argv = (sys.argv[:1] + setup_command +
TypeError: can only concatenate list (not "str") to list

ERROR Backend subproccess exited when trying to invoke build_wheel

@hodgestar
Copy link
Contributor Author

It did work for me with QuTiP master on Python 3.10.5. Could you try with master to? We need to do a 4.7.1 release soon anyway.

@hodgestar
Copy link
Contributor Author

If master fails, could you let me know which versions of build and setuptools you're using?

Copy link
Member

@Ericgig Ericgig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.
We just need remember to remove the filter when the fix is made.

@hodgestar hodgestar merged commit 10ea88d into qutip:master Aug 18, 2022
@hodgestar
Copy link
Contributor Author

@drew-parsons I'll leave #1875 open until we've sorted out why the --config-setting=--global-option=--with-openmp isn't working in some cases.

@drew-parsons
Copy link
Contributor

drew-parsons commented Aug 18, 2022

No, --config-setting=--global-option=--with-openmp is still not working with git head. This is with

  • python 3.10.6-1
  • python3-build 0.7.0-3
  • python3-setuptools 59.6.0-1.2
  • python3-wheel 0.37.1-2
  • gcc 12.1.0-7

@hodgestar hodgestar deleted the feature/silence-pyximport-relative-error-warning branch December 10, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants