Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where opening a file whose name contains characters not present in locale would cause a crash. #3177

Merged
merged 4 commits into from
Nov 7, 2017
Merged

Fix issue where opening a file whose name contains characters not present in locale would cause a crash. #3177

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bdfb9c6
Fix issue where opening a file whose name contains characters not
Oct 21, 2017
96eff65
Log when url contains characters not present in current locale.
lejar Oct 22, 2017
f53d813
Add test for opening non-ascii paths.
lejar Oct 22, 2017
f67c445
Add test for opening non-ascii paths from command line.
lejar Oct 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions qutebrowser/utils/urlutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,8 +372,14 @@ def get_path_if_valid(pathstr, cwd=None, relative=False, check_exists=False):
path = None

if check_exists:
if path is not None and os.path.exists(path):
log.url.debug("URL is a local file")
if path is not None:
# If the path contains characters that the locale cannot handle,
# then we consider it as non-existent.
try:
if os.path.exists(path):
log.url.debug("URL is a local file")
except UnicodeEncodeError:
path = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea to log this as debug, the same way the other branch gets logged.

else:
path = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this else: anymore as we just do if path is not None: above now.


Expand Down