Remove QUnit.extend() #1696
Open
Remove QUnit.extend() #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krinkle
reviewed
Jul 6, 2022
Krinkle
reviewed
Jul 8, 2022
docs/removed.md
Outdated
| @@ -1,5 +1,46 @@ | |||
| --- | |||
| layout: group | |||
| title: QUnit.extend() | |||
There was a problem hiding this comment.
This is the index file for the group, similar to deprecated.md and extension/index.md. It will list the pages that use that group.
I think removing extend from the extension group is fine, but perhaps keep it in that directory for now for its URL continuity. We could possibly move it to a new directory as well for removed things if we want the URL to change (and keep a redirect), but the removed.md file is not meant to have its own page content.
Sorry about the confusion :)
There was a problem hiding this comment.
Should I create a removed folder and move the file there? I removed the docs change commit for now ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During my code removals I already saw that this method is deprecated and planned to be removed in v3. This PR could serve as the removal commit(s) if it gets merged, otherwise feel free to close the PR ;)