Core: improve warning for incorrect module hook usage

[chriskrycho]

Add the names of the relevant modules so the message is more actionable for users who encounter it.

Fixes #1647

@Krinkle, this is failing tests locally (and presumably on CI here!) for CLI Main > mapped trace with native source map, presumably because it needs the fixture regenerated. I’m happy to update the fixture given guidance to that end!

[Krinkle]

@chriskrycho Seems to pass here. Mind sharing the failure details? My guess it's a false negative from a newer Node version emitting slightly different source maps or perhaps new internal stack frame somewhere.

[chriskrycho]

Ah, it is indeed likely a newer version. I’m running Node 14 LTS locally. (I have gotten spoiled by Volta keeping these things in sync for me over the last couple years!)

[chriskrycho]

I’ll add the failure details in a new issue when I’m back at my work laptop tomorrow!

[chriskrycho]

The error message report:

not ok 52 CLI Main > mapped trace with native source map
  ---
  message: failed
  severity: failed
  actual  : |+
    TAP version 13
    ok 1 Example > good
    not ok 2 Example > bad
      ---
      message: failed
      severity: failed
      actual  : false
      expected: true
      stack: |
            at /qunit/test/cli/fixtures/sourcemap/source.min.js:1:133
                -> /qunit/test/cli/fixtures/sourcemap/sourcemap/source.js:7:10
      ...
    1..2
    # pass 1
    # skip 0
    # todo 0
    # fail 1
  expected: |+
    TAP version 13
    ok 1 Example > good
    not ok 2 Example > bad
      ---
      message: failed
      severity: failed
      actual  : false
      expected: true
      stack: |
            at /qunit/test/cli/fixtures/sourcemap/sourcemap/source.js:7:10
      ...
    1..2
    # pass 1
    # skip 0
    # todo 0
    # fail 1
  stack: |
        at Object.<anonymous> (/Users/ckrycho/dev/qunitjs/qunit/test/cli/cli-main.js:401:13)
        at processTicksAndRejections (internal/process/task_queues.js:93:5)
  ...

[Krinkle]

Interesting. We run Node 14 in CI as well, and there Node.js reports source-mapped traces as input.min -> mapped.source instead of only mapped.source. We normalize them in execute.js. Feel free to poke around if it interests you. Otherwise, I might get around to it next week when releasing this.

[chriskrycho]

Curious. Unfortunately I will not have time to fix it, as I have other open-source things which need to be a higher priority, but thank you in any case for the quick response and turn-around here! Very much appreciated.