Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Upgrade js-reporters to 2.0.0 #1577

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Conversation

Krinkle
Copy link
Member

@Krinkle Krinkle commented Apr 4, 2021

@Krinkle
Copy link
Member Author

Krinkle commented Apr 4, 2021

@smcclure15 I believe the issue you looked at in #1407 is also fixed by this. However I'm not able to reproduce the issue the same way as before. Would appreciate a second look by you as well to make sure it is indeed addressed.

@Krinkle Krinkle closed this Apr 4, 2021
@Krinkle Krinkle reopened this Apr 4, 2021
@Krinkle Krinkle closed this Apr 4, 2021
@Krinkle Krinkle reopened this Apr 4, 2021
@smcclure15
Copy link
Member

@smcclure15 I believe the issue you looked at in #1407 is also fixed by this... Would appreciate a second look by you as well to make sure it is indeed addressed.

Confirmed!
I transplanted js-reporters 2.0.0 alongside our current QUnit 2.11.2 version as well as latest 2.14.1 and the issue looks to be resolved in either case.

@Krinkle Krinkle closed this Apr 9, 2021
@Krinkle Krinkle deleted the cli-jsrep2 branch April 9, 2021 19:17
@Krinkle Krinkle restored the cli-jsrep2 branch April 9, 2021 19:53
@Krinkle Krinkle reopened this Apr 9, 2021
@Krinkle Krinkle merged commit ae24a16 into qunitjs:main Apr 9, 2021
@Krinkle Krinkle deleted the cli-jsrep2 branch April 9, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment