Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Set up redirects for old urls #1292

Merged
merged 1 commit into from Jun 17, 2018
Merged

Docs: Set up redirects for old urls #1292

merged 1 commit into from Jun 17, 2018

Conversation

Krinkle
Copy link
Member

@Krinkle Krinkle commented Jun 17, 2018

Fixes #1289.


Follows proof-of-concept from #1291 which worked. https://api.qunitjs.com/QUnit/stop now redirects to http://api.qunitjs.com/assert/async.

Copy link
Contributor

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general.

Wondering if we could enable some plugin to strip or add a trailing slash for all incoming requests? If so, we could maybe remove half of the redirect listings. Of course, that's beyond the scope of this PR.

@Krinkle Krinkle merged commit a7ccfcb into master Jun 17, 2018
@Krinkle Krinkle deleted the docs-redir branch June 17, 2018 23:27
@Krinkle
Copy link
Member Author

Krinkle commented Jun 17, 2018

@platinumazure Yeah, good idea.

I'll land this without it for now, though. In particular because it's a limited set of known urls and their variants, particularly because the old site supported the variant.

However, for the current urls there's a less strong need for it, given the variant with or without slash never worked for those urls, which means they shouldn't be reachable through normal link discovery. However, to be friendly to url-hackery and to tolerate broken tooling that may accidentally remove or add a slash, I'd certainly support making it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants