Skip to content

Commit

Permalink
Test: Change tests to not rely on "double done" hack
Browse files Browse the repository at this point in the history
The next commit in this branch for #1511, will disallow adding
tests if `QUnit.done()` and `runEnd` have already happened, thus
leading these hacks to fail as follows:

````
Running "qunit:all" (qunit) task
Testing http://localhost:4000/test/index.html
[…]
Testing http://localhost:4000/test/module-skip.html ....
Error: Unexpected new test after the run already ended
    at new Test (http://localhost:4000/qunit/qunit.js:2206:13)
^C
```

In addition, due to a known issue in grunt-contrib-qunit, these would
also indefinitely hack instead of actually failing.

Ref gruntjs/grunt-contrib-qunit#178.
Ref #1377.
Ref #1511.
  • Loading branch information
Krinkle committed Jul 3, 2021
1 parent da48c66 commit 78bda44
Show file tree
Hide file tree
Showing 12 changed files with 307 additions and 425 deletions.
4 changes: 0 additions & 4 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,6 @@ module.exports = function( grunt ) {
"test/reorder.html",
"test/reorderError1.html",
"test/reorderError2.html",
"test/callbacks.html",
"test/callbacks-promises.html",
"test/events.html",
"test/events-filters.html",
"test/events-in-test.html",
"test/logs.html",
Expand Down Expand Up @@ -128,7 +125,6 @@ module.exports = function( grunt ) {
"test/main/deepEqual.js",
"test/main/stack.js",
"test/main/utilities.js",
"test/events.js",
"test/events-in-test.js",
"test/onerror/inside-test.js",
"test/onerror/outside-test.js",
Expand Down
14 changes: 0 additions & 14 deletions test/callbacks-promises.html

This file was deleted.

129 changes: 0 additions & 129 deletions test/callbacks-promises.js

This file was deleted.

14 changes: 0 additions & 14 deletions test/callbacks.html

This file was deleted.

174 changes: 0 additions & 174 deletions test/callbacks.js

This file was deleted.

0 comments on commit 78bda44

Please sign in to comment.