Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brief clarification on scenario compatibility #4151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomas-qah
Copy link
Contributor

@thomas-qah thomas-qah commented Oct 6, 2023

What?

This PR adds a brief line explaining what it means if the scenario version is different from the current model version.

Why?

To make the user aware of the possible implications of older scenario versions.

How?

See changes.

Closes #4145

@thomas-qah thomas-qah self-assigned this Oct 6, 2023
@mabijkerk
Copy link
Member

mabijkerk commented Oct 18, 2023

Two points of feedback:

  1. The Dutch translation seems to be missing
  2. I'm not sure this solves Update text on compatibility when viewing scenario description #4145, as I see it, this PR only adds a more extensive explanation. What the issue describes is that users do not know if their scenario is being kept up to date or not. I feel the goal of the issue would be to make clear to the user if keep_compatible is set to true or false. Do you agree @noracato?

To expand on 2. I think that the we have the following options, that we want to clarify to our users:

  • Keep_compatible is set to false and there has been a Deploy: the scenario is not changed, but there is a risk that it is broken
  • Keep_compatible is set to true and there has been a Deploy: the scenario may be changed, but there is no risk that it is borken

Copy link

This pull request has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

@github-actions github-actions bot added the Stale Issue had no activity for 60 days and will be, or has been, closed. label Dec 18, 2023
@mabijkerk mabijkerk removed the Stale Issue had no activity for 60 days and will be, or has been, closed. label Dec 20, 2023
Copy link

This pull request has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

@github-actions github-actions bot added the Stale Issue had no activity for 60 days and will be, or has been, closed. label Feb 19, 2024
@mabijkerk mabijkerk removed the Stale Issue had no activity for 60 days and will be, or has been, closed. label Feb 19, 2024
@mabijkerk mabijkerk added the Pinned Will never be marked as stale or auto-closed. label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pinned Will never be marked as stale or auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update text on compatibility when viewing scenario description
2 participants