Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update text on compatibility when viewing scenario description #4145

Open
noracato opened this issue Sep 28, 2023 · 2 comments · May be fixed by #4151
Open

Update text on compatibility when viewing scenario description #4145

noracato opened this issue Sep 28, 2023 · 2 comments · May be fixed by #4151
Assignees
@noracato @mabijkerk
Labels
Pinned Will never be marked as stale or auto-closed.

Comments

@noracato
Copy link
Member

noracato commented Sep 28, 2023 •
edited by thomas-qah

The text on the scenario's compatibility can be a bit ambiguous.

Screenshot 2023-09-28 at 14 50 25

It's unclear if the scenario is being kept up-to-date or not and if these mentioned latest updates have had any influence. We should update this text to be more clear:

  • Explain what the current description means: is the scenario still compatible or not?
@mabijkerk mabijkerk changed the title Update text on compatiblity when viewing scenario description Update text on compatibility when viewing scenario description Sep 29, 2023
@thomas-qah thomas-qah mentioned this issue Oct 2, 2023
Closed
@mabijkerk
Copy link
Member

Sounds good, but one thing to keep in mind is that scenario versions is something different than scenario migrations. Say we update some node attributes and the model is deployed, there is a new version of the model. This newer version may have implications for the scenario, even though there may not have been any scenario migrations affecting the scenario.

@thomas-qah thomas-qah linked a pull request Oct 6, 2023 that will close this issue
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2023

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

@github-actions github-actions bot added the Stale Issue had no activity for 60 days and will be, or has been, closed. label Dec 3, 2023
@mabijkerk mabijkerk added Pinned Will never be marked as stale or auto-closed. and removed Stale Issue had no activity for 60 days and will be, or has been, closed. labels Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noracato noracato

@mabijkerk mabijkerk

Labels
Pinned Will never be marked as stale or auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add brief clarification on scenario compatibility quintel/etmodel
2 participants
@noracato @mabijkerk